Bug 117996 – CSSRuleList.cpp and CSSGroupingRule.cpp should include <wtf/MemoryInstrumentationVector.h>

• Component: CSS
• Status: RESOLVED INVALID

CSSRuleList.cpp and CSSGroupingRule.cpp use:

void WTF::reportMemoryUsage<WTF::RefPtr<WebCore::CSSRule>, 0ul>(WTF::Vector<WTF::RefPtr<WebCore::CSSRule>, 0ul> const*, WTF::MemoryObjectInfo*)

but do not include the template header that defines this function.

This gives a linker error when building with -fprofile-generate.

The fix is simple:


Index: Source/core/css/CSSGroupingRule.cpp
===================================================================
--- Source/core/css/CSSGroupingRule.cpp	(revision 152906)
+++ Source/core/css/CSSGroupingRule.cpp	(working copy)
@@ -32,6 +32,7 @@
 
 #include "core/css/CSSGroupingRule.h"
 
+#include <wtf/MemoryInstrumentationVector.h>
 #include "core/css/CSSParser.h"
 #include "core/css/CSSRuleList.h"
 #include "core/css/CSSStyleSheet.h"
Index: Source/core/css/CSSRuleList.cpp
===================================================================
--- Source/core/css/CSSRuleList.cpp	(revision 152906)
+++ Source/core/css/CSSRuleList.cpp	(working copy)
@@ -22,6 +22,7 @@
 #include "config.h"
 #include "core/css/CSSRuleList.h"
 
+#include <wtf/MemoryInstrumentationVector.h>
 #include "core/css/CSSRule.h"
 
 namespace WebCore {

Created attachment 205409 [details]
Patch

Comment on attachment 205409 [details]
Patch

Please take a look at the patch and give me some feedback.

[Build Bot]

Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/869796

[EFL EWS Bot]

Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/948246

[Early Warning System Bot]

Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/976104

[EFL EWS Bot]

Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/976105

[Early Warning System Bot]

Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/976106

[kov's GTK+ EWS bot]

Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/948248

Sorry about the noise. This problem is only in Blink, not in WebKit.