Bug 117984

Summary: Rearrange the code of FrameWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 117988    
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, bfulgham: commit-queue-
Patch for landing none

Patrick R. Gansterer
Reported 2013-06-25 05:48:46 PDT
Rearrange the code of FrameWin
Attachments
Patch (8.09 KB, patch)
2013-06-25 05:55 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (8.61 KB, patch)
2013-06-25 06:02 PDT, Patrick R. Gansterer 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (8.72 KB, patch)
2013-08-01 05:36 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-06-25 05:55:21 PDT
Created attachment 205390 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-25 05:56:22 PDT
Attachment 205390 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/win/FrameCGWin.cpp', u'Source/WebCore/page/win/FrameCairoWin.cpp', u'Source/WebCore/page/win/FrameWin.cpp', u'Source/WebCore/page/win/FrameWin.h', u'Source/WebKit/win/WebView.cpp']" exit_code: 1 Source/WebCore/page/win/FrameWin.cpp:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 3 2013-06-25 06:02:25 PDT
Created attachment 205392 [details] Patch
Brent Fulgham
Comment 4 2013-07-30 09:27:00 PDT
Comment on attachment 205392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205392&action=review I think the imageFromRect method should take a const Frame* argument. Otherwise, this looks good to me. Please correct the const when you land it. > Source/WebCore/page/win/FrameCGWin.cpp:52 > +PassOwnPtr<HBITMAP> imageFromRect(Frame* frame, IntRect& ir) Why remove the 'const' from the Frame* argument?
Brent Fulgham
Comment 5 2013-07-30 09:28:15 PDT
Also, I think the ChangeLog should be a bit more descriptive, since you: 1. Shared more code between WinCairo and Windows. 2. Made use of our safer pointer types. Also, please fix the spaces in FrameWin.cpp when you land.
Patrick R. Gansterer
Comment 6 2013-08-01 05:36:29 PDT
Created attachment 207914 [details] Patch for landing
Brent Fulgham
Comment 7 2013-08-01 09:00:33 PDT
Comment on attachment 207914 [details] Patch for landing r=me
WebKit Commit Bot
Comment 8 2013-08-01 09:22:00 PDT
Comment on attachment 207914 [details] Patch for landing Clearing flags on attachment: 207914 Committed r153586: <http://trac.webkit.org/changeset/153586>
WebKit Commit Bot
Comment 9 2013-08-01 09:22:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.