Rearrange the code of FrameWin

• Component: Platform
• Status: RESOLVED FIXED

[Patrick R. Gansterer]

Rearrange the code of FrameWin

[Patrick R. Gansterer]

Created attachment 205390 [details]
Patch

[WebKit Commit Bot]

Attachment 205390 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/win/FrameCGWin.cpp', u'Source/WebCore/page/win/FrameCairoWin.cpp', u'Source/WebCore/page/win/FrameWin.cpp', u'Source/WebCore/page/win/FrameWin.h', u'Source/WebKit/win/WebView.cpp']" exit_code: 1
Source/WebCore/page/win/FrameWin.cpp:55:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Patrick R. Gansterer]

Created attachment 205392 [details]
Patch

[Brent Fulgham]

Comment on attachment 205392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205392&action=review

I think the imageFromRect method should take a const Frame* argument.  Otherwise, this looks good to me.  Please correct the const when you land it.

> Source/WebCore/page/win/FrameCGWin.cpp:52
> +PassOwnPtr<HBITMAP> imageFromRect(Frame* frame, IntRect& ir)

Why remove the 'const' from the Frame* argument?

[Brent Fulgham]

Also, I think the ChangeLog should be a bit more descriptive, since you:
1. Shared more code between WinCairo and Windows.
2. Made use of our safer pointer types.

Also, please fix the spaces in FrameWin.cpp when you land.

[Patrick R. Gansterer]

Created attachment 207914 [details]
Patch for landing

[Brent Fulgham]

Comment on attachment 207914 [details]
Patch for landing

r=me

[WebKit Commit Bot]

Comment on attachment 207914 [details]
Patch for landing

Clearing flags on attachment: 207914

Committed r153586: <http://trac.webkit.org/changeset/153586>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.