Summary: | Adopt is/toHTMLAreaElement for code cleanup | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kangil Han <kangil.han> | ||||||||
Component: | WebCore Misc. | Assignee: | Kangil Han <kangil.han> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, kling, koivisto | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Kangil Han
2013-06-25 05:21:36 PDT
Created attachment 205384 [details]
Patch
Comment on attachment 205384 [details]
Patch
I think toHTMLAreaElement makes sense, given that there are other similar toXXX functions around.
I am not sure isHTMLAreaElement does, though.
In the same line now you have things like if (isHTMLAreaElement() ||bleh->hasTagName(blah))
(In reply to comment #2) > (From update of attachment 205384 [details]) > I think toHTMLAreaElement makes sense, given that there are other similar toXXX functions around. > > I am not sure isHTMLAreaElement does, though. > > In the same line now you have things like if (isHTMLAreaElement() ||bleh->hasTagName(blah)) Don't worry. I've made patches to adopt is/toFooElement for all FooElements. :) As patches are landed, we won't see blah things you mentioned. ;) Comment on attachment 205384 [details]
Patch
Ok
(In reply to comment #4) > (From update of attachment 205384 [details]) > Ok Thx! Comment on attachment 205384 [details] Patch Rejecting attachment 205384 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 205384, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: tTestResult.cpp Hunk #1 FAILED at 29. Hunk #2 FAILED at 511. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/HitTestResult.cpp.rej patching file Source/WebCore/rendering/RenderImage.cpp patching file Source/WebKit/blackberry/Api/WebPage.cpp patching file Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antonio Gomes']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/965833 Created attachment 205483 [details]
Patch
Comment on attachment 205483 [details] Patch Rejecting attachment 205483 [details] from commit-queue. New failing tests: media/track/media-element-enqueue-event-crash.html Full output: http://webkit-queues.appspot.com/results/930472 Created attachment 205495 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Try one more since this patch doesn't touch media stuff. :) Comment on attachment 205483 [details] Patch Clearing flags on attachment: 205483 Committed r151996: <http://trac.webkit.org/changeset/151996> All reviewed patches have been landed. Closing bug. |