Summary: | [CSS 3] missing cursor support for 'none' | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lars Næsbye Christensen <lars> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Lars Næsbye Christensen
2006-12-10 14:11:21 PST
Created attachment 11793 [details]
patch to support CSS 3 'none' cursor selector
Comment on attachment 11793 [details]
patch to support CSS 3 'none' cursor selector
Looks fine for Mac, but I'd like to see a patch that keeps the other platforms compiling too.
Comment on attachment 11793 [details]
patch to support CSS 3 'none' cursor selector
Marking review- just because of the "no changes for the other platforms" issue. Please submit a patch that at least tries to keep all the platforms working.
Created attachment 11848 [details]
patch v2 - with more platforms
Point taken. This should at least provide some default results.
Comment on attachment 11848 [details]
patch v2 - with more platforms
r=me
Qt has BlankCursor; I'm going to tweak the patch to use it instead of pointer when landing.
(In reply to comment #5) That sounds nice :-) And yes, I should be more mindful about making sure they all compile. Committed revision 18270. I also had to fix cssparser.cpp: when changing CSS value IDs, one needs to make sure that the calculations are still correct. This patch broke border/outline properties entirely, and an earlier cursor patch broke -webkit-background-composite: copy. What do you think about adding support for Mozilla cursors (bug 8988)? I'm not sure what our policy on Mozilla CSS extensions is (currently, we don't support any -moz- properties), but those cursors look pretty useful. (In reply to comment #7) Well, unless there's a general attitude against them, I don't see why we shouldn't include them. It'd be a pleasure. As far as I can see, it's the grab/grabbing and zoom in/out cursors we need to add. However, I spotted that some of the existing cursor images have bad transparency and other issues. Also, we could really do with a more modern, OSX-ish set of cursors generally. 16x16 B/W and no drop shadows? We can do better, and I think that's priority #1 :-) |