Bug 117979

Summary: [GTK][WK2][Stable] Cannot make debug builds of the stable branch
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Alberto Garcia
Reported 2013-06-25 05:06:44 PDT
Here's the error message: Source/WebKit2/PluginProcess/unix/Programs_WebKitPluginProcess-PluginProcessMainUnix.o: In function `webkitXError': Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:68: undefined reference to `WebKit::LogPlugins' Source/WebKit2/Shared/Programs_WebKitPluginProcess-WebKit2Initialize.o: In function `WebKit::InitializeWebKit2()': Source/WebKit2/Shared/WebKit2Initialize.cpp:53: undefined reference to `WebKit::initializeLogChannelsIfNecessary()'
Attachments
Patch (1.44 KB, patch)
2013-06-25 05:08 PDT, Alberto Garcia 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-06-25 05:08:51 PDT
Created attachment 205383 [details] Patch
Zan Dobersek
Comment 2 2013-06-25 07:27:51 PDT
Comment on attachment 205383 [details] Patch Alternatively you could add libWebKit2Platform.la to the list of Programs_WebKitPluginProcess_LDADD. That's what solves the issue in trunk, it seems.
Carlos Garcia Campos
Comment 3 2013-06-25 10:05:31 PDT
In trunk we build libWebKit2Platform as a separate library and the plugin process links to it, IIRC
Zan Dobersek
Comment 4 2013-06-25 10:08:25 PDT
(In reply to comment #3) > In trunk we build libWebKit2Platform as a separate library and the plugin process links to it, IIRC Correct, libWebKit2Platform didn't make it into the 2.0 branch, so I guess the proposed patch is just fine.
Alberto Garcia
Comment 5 2013-06-25 22:56:57 PDT
(In reply to comment #4) > (In reply to comment #3) > > In trunk we build libWebKit2Platform as a separate library and the plugin process links to it, IIRC > > Correct, libWebKit2Platform didn't make it into the 2.0 branch, so I guess the proposed patch is just fine. That was the idea.
Carlos Garcia Campos
Comment 6 2013-06-26 01:17:27 PDT
Merged in stable branch <http://trac.webkit.org/changeset/151983>
Note You need to log in before you can comment on or make changes to this bug.