Bug 117969

Summary: Don't snapshot plug-ins that come from the same host as the page
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, jonlee, rniwa, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion none

Description Dean Jackson 2013-06-24 20:38:20 PDT
Typically if a page has a plug-in that is served from the same host, it's content that is important to the site. Make sure we don't snapshot that content.

<rdar://problem/12885400>
Comment 1 Dean Jackson 2013-06-24 20:41:09 PDT
Created attachment 205359 [details]
Patch
Comment 2 Jon Lee 2013-06-24 21:10:23 PDT
Comment on attachment 205359 [details]
Patch

LGTM. r=me
Comment 3 Build Bot 2013-06-25 00:43:59 PDT
Comment on attachment 205359 [details]
Patch

Attachment 205359 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/960850

New failing tests:
svg/batik/filters/feTile.svg
Comment 4 Build Bot 2013-06-25 00:44:00 PDT
Created attachment 205370 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 5 Tim Horton 2013-06-25 12:52:07 PDT
Comment on attachment 205359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205359&action=review

r+ but talk to Darin about impact, as discussed.

> Source/WebCore/ChangeLog:14
> +            Add a test that compares the plug-in's URL against the main page's

This looks indented strangely.
Comment 6 Dean Jackson 2013-06-25 14:49:04 PDT
Committed r151971: <http://trac.webkit.org/changeset/151971>