Bug 117956

Summary: [BlackBerry] Only resume root layer commits for visible WebPages
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, cgarcia, commit-queue, rwlbuis, xiaobwang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jakob Petsovits
Reported 2013-06-24 15:45:26 PDT
In r150629, the code from that change introduced to suspend and resume root layer commits would not take into account whether the page is actually visible. Because application activation state is usually conveyed to all or any WebPages, this would mean on transitioning into an active application state, we were resuming root layer commits that might have previously been disabled for visibility reasons. The patch below fixes this by going through a single function that knows by itself whether to suspend or resume root layer commits, so the calling code doesn't have a chance to get it wrong.
Attachments
Patch (4.46 KB, patch)
2013-06-24 15:48 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-06-24 15:48:42 PDT
Created attachment 205337 [details] Patch
George Staikos
Comment 2 2013-06-24 16:32:33 PDT
Comment on attachment 205337 [details] Patch This looks cleaner too.
WebKit Commit Bot
Comment 3 2013-06-24 17:06:18 PDT
Comment on attachment 205337 [details] Patch Clearing flags on attachment: 205337 Committed r151936: <http://trac.webkit.org/changeset/151936>
WebKit Commit Bot
Comment 4 2013-06-24 17:06:21 PDT
All reviewed patches have been landed. Closing bug.
Jakob Petsovits
Comment 5 2013-06-25 08:06:16 PDT
Appendix: See https://bugs.webkit.org/show_bug.cgi?id=115245 for the original patch that got fixed up by this one here.
Note You need to log in before you can comment on or make changes to this bug.