Bug 117949

Summary:

WebKit should link to opengl32.lib on Windows

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

bfulgham, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	none

Alex Christensen

Reported 2013-06-24 14:50:44 PDT

Linking to opengl32.lib will allow enabling WebGL, but it won't change anything with WebGL not enabled because it currently links successfully without it.

Attachments
Patch (2.42 KB, patch) 2013-06-24 14:52 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-06-24 14:52:22 PDT

Created attachment 205329 [details] Patch

Brent Fulgham

Comment 2 2013-06-24 15:11:53 PDT

Comment on attachment 205329 [details] Patch Looks fine. Let's allow the EWS to run on it, then land it if it's fine.

Alex Christensen

Comment 3 2013-06-24 17:05:50 PDT

EWS has had its chance. I can apply the patch, even if the windows bot can't. I'm going to cq+ it and we'll see if it gets through the commit queue. We can roll it out if it breaks the build, but I've built successfully with this.

WebKit Commit Bot

Comment 4 2013-06-24 17:15:38 PDT

Comment on attachment 205329 [details] Patch Clearing flags on attachment: 205329 Committed r151937: <http://trac.webkit.org/changeset/151937>

WebKit Commit Bot

Comment 5 2013-06-24 17:15:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.