Bug 117943

Summary: [WK2] Make sure m_iconDatabaseImpl is not null before closing it
Product: WebKit Reporter: Nick Diego Yamane (diegoyam) <nick.diego>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Nick Diego Yamane (diegoyam) 2013-06-24 13:19:05 PDT 
Make sure m_iconDatabaseImpl is not null before closing it
Comment 1 Nick Diego Yamane (diegoyam) 2013-06-24 13:24:15 PDT 
Created attachment 205321 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-06-24 14:27:36 PDT 
Is this a crash observed in the field, or when running tests?
Comment 3 Nick Diego Yamane (diegoyam) 2013-06-24 15:22:27 PDT 
Since r150474 WebIconDatabase is closed unconditionally in TestController destructor, in that case WebKitTestRunner crashes when no icon database path is set. This misbehavior was observed in ports such as efl and nix.
Comment 4 Nick Diego Yamane (diegoyam) 2013-06-24 15:23:36 PDT 
Created attachment 205333 [details]
Patch

proposed patch
Comment 5 WebKit Commit Bot 2013-06-24 15:50:01 PDT 
Comment on attachment 205333 [details]
Patch

Clearing flags on attachment: 205333

Committed r151932: <http://trac.webkit.org/changeset/151932>
Comment 6 WebKit Commit Bot 2013-06-24 15:50:03 PDT 
All reviewed patches have been landed.  Closing bug.