Bug 117943

Summary: [WK2] Make sure m_iconDatabaseImpl is not null before closing it
Product: WebKit Reporter: Nick Diego Yamane (diegoyam) <nick.diego>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nick Diego Yamane (diegoyam)
Reported 2013-06-24 13:19:05 PDT
Make sure m_iconDatabaseImpl is not null before closing it
Attachments
Patch (1.28 KB, patch)
2013-06-24 13:24 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2013-06-24 15:23 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-06-24 13:24:15 PDT
Created attachment 205321 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-06-24 14:27:36 PDT
Is this a crash observed in the field, or when running tests?
Nick Diego Yamane (diegoyam)
Comment 3 2013-06-24 15:22:27 PDT
Since r150474 WebIconDatabase is closed unconditionally in TestController destructor, in that case WebKitTestRunner crashes when no icon database path is set. This misbehavior was observed in ports such as efl and nix.
Nick Diego Yamane (diegoyam)
Comment 4 2013-06-24 15:23:36 PDT
Created attachment 205333 [details] Patch proposed patch
WebKit Commit Bot
Comment 5 2013-06-24 15:50:01 PDT
Comment on attachment 205333 [details] Patch Clearing flags on attachment: 205333 Committed r151932: <http://trac.webkit.org/changeset/151932>
WebKit Commit Bot
Comment 6 2013-06-24 15:50:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.