Bug 117934 – [EFL] Unable to load and render .mht file from local filesystem, Instead it gets download

• Component: WebKit EFL
• Status: RESOLVED WORKSFORME

[Santosh Mahto]

Currently mhtml files present in local filesystem are not loaded and rendered, 
Instead its get downloaded.

Currently the mime-type used for EFl is message/rfc822 not "application/x-mimearchive"
and  message/rfc822 is not in the list of mimetype that can be displayed.

http://trac.webkit.org/changeset/150418 is a bit related to this.

[Santosh Mahto]

Created attachment 205293 [details]
Patch

[Chris Dumez]

Comment on attachment 205293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205293&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] Unable to load and render .mht file from local filesystem, Instead it gets download

"downloaded"

> Source/WebCore/loader/archive/ArchiveFactory.cpp:70
> +#if PLATFORM(EFL)

This is a layering violation. We are not supposed to platform-specific code outside platform/ folder.

[Santosh Mahto]

Created attachment 205378 [details]
Patch

[Santosh Mahto]

> 
> > Source/WebCore/loader/archive/ArchiveFactory.cpp:70
> > +#if PLATFORM(EFL)
 #if PLATFORM(EFL) is not required here also.
so removing it 

> This is a layering violation. We are not supposed to platform-specific code outside platform/ folder.

[Ryuan Choi]

(In reply to comment #4)
> > 
> > > Source/WebCore/loader/archive/ArchiveFactory.cpp:70
> > > +#if PLATFORM(EFL)
>  #if PLATFORM(EFL) is not required here also.
> so removing it 
> 
> > This is a layering violation. We are not supposed to platform-specific code outside platform/ folder.

Could you check https://bugs.webkit.org/show_bug.cgi?id=7168 (especially from #46 to #54 ) ?

And https://bugs.webkit.org/show_bug.cgi?id=89978 .

[Chris Dumez]

Comment on attachment 205378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205378&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] Unable to load and render .mht file from local filesystem,

This patch is no longer EFL specific, please remobe [EFL] tag.

> Source/WebCore/ChangeLog:8
> +

Missing Changelog.

[Chris Dumez]

Comment on attachment 205378 [details]
Patch

Oh and why no layout test?

[Santosh Mahto]

After looking at https://bugs.webkit.org/show_bug.cgi?id=89978
it seems mimetype for .mht file is decided by deep platform code
WKGTK -> libsoup -> GIO -> GVFS -> GNOME-VFS -> shared-mime-info (from freedesktop.org)

and it looks previously "messgae/rfc822 " was correct mimeType for some platform.

but from  https://bugs.webkit.org/show_bug.cgi?id=116442 
it looks the actual issue in platform is fixed  this year.
by : http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=5dc7a385dfde27baabbe7384e69605c48adbf1e4.

and so GTK port have removed "messgae/rfc822 " as mimetype  for mht file.



So I doubt mht file is not loading in my PC becasue my pc has old OS. Can anyone try in latest ??

Can we still add this patch for backward-compatibilty?? as platform fix is made recently, so i had a thought

[Ryuan Choi]

(In reply to comment #8)
> After looking at https://bugs.webkit.org/show_bug.cgi?id=89978
> it seems mimetype for .mht file is decided by deep platform code
> WKGTK -> libsoup -> GIO -> GVFS -> GNOME-VFS -> shared-mime-info (from freedesktop.org)
> 
> and it looks previously "messgae/rfc822 " was correct mimeType for some platform.
> 
> but from  https://bugs.webkit.org/show_bug.cgi?id=116442 
> it looks the actual issue in platform is fixed  this year.
> by : http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=5dc7a385dfde27baabbe7384e69605c48adbf1e4.
> 
> and so GTK port have removed "messgae/rfc822 " as mimetype  for mht file.
> 
> 
> 
> So I doubt mht file is not loading in my PC becasue my pc has old OS. Can anyone try in latest ??

I saved and loaded webkit.org using MiniBrowser/Efl and it works fine to me.
Is it enough?

I am using ubuntu 13.04 and jhbuild

> 
> Can we still add this patch for backward-compatibilty?? as platform fix is made recently, so i had a thought

[Santosh Mahto]

(In reply to comment #9)
> (In reply to comment #8)
> > After looking at https://bugs.webkit.org/show_bug.cgi?id=89978
> > it seems mimetype for .mht file is decided by deep platform code
> > WKGTK -> libsoup -> GIO -> GVFS -> GNOME-VFS -> shared-mime-info (from freedesktop.org)
> > 
> > and it looks previously "messgae/rfc822 " was correct mimeType for some platform.
> > 
> > but from  https://bugs.webkit.org/show_bug.cgi?id=116442 
> > it looks the actual issue in platform is fixed  this year.
> > by : http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=5dc7a385dfde27baabbe7384e69605c48adbf1e4.
> > 
> > and so GTK port have removed "messgae/rfc822 " as mimetype  for mht file.
> > 
> > 
> > 
> > So I doubt mht file is not loading in my PC becasue my pc has old OS. Can anyone try in latest ??
> 
> I saved and loaded webkit.org using MiniBrowser/Efl and it works fine to me.
> Is it enough?
> 
> I am using ubuntu 13.04 and jhbuild
sounds its working,
 but can you try as to make final confirmation:
save any page.
then open any other page( to replace the current page)
now load the saved page.

Actually in directly  saving and fetching the url bar shows the .mht  but
page on screen is old page.So it appears that .mht is loaded.

OR in MiniBrowser  you can see the logs.

If it works then  only question is of backward-compatibilty
I am trying ubuntu 12.04 and jhbuild and its not loading.

[Ryuan Choi]

(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > After looking at https://bugs.webkit.org/show_bug.cgi?id=89978
> > > it seems mimetype for .mht file is decided by deep platform code
> > > WKGTK -> libsoup -> GIO -> GVFS -> GNOME-VFS -> shared-mime-info (from freedesktop.org)
> > > 
> > > and it looks previously "messgae/rfc822 " was correct mimeType for some platform.
> > > 
> > > but from  https://bugs.webkit.org/show_bug.cgi?id=116442 
> > > it looks the actual issue in platform is fixed  this year.
> > > by : http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=5dc7a385dfde27baabbe7384e69605c48adbf1e4.
> > > 
> > > and so GTK port have removed "messgae/rfc822 " as mimetype  for mht file.
> > > 
> > > 
> > > 
> > > So I doubt mht file is not loading in my PC becasue my pc has old OS. Can anyone try in latest ??
> > 
> > I saved and loaded webkit.org using MiniBrowser/Efl and it works fine to me.
> > Is it enough?
> > 
> > I am using ubuntu 13.04 and jhbuild
> sounds its working,
>  but can you try as to make final confirmation:
> save any page.
> then open any other page( to replace the current page)
> now load the saved page.
> 
> Actually in directly  saving and fetching the url bar shows the .mht  but
> page on screen is old page.So it appears that .mht is loaded.
> 
> OR in MiniBrowser  you can see the logs.

I tested load and save at different minibrowser process.

> 
> If it works then  only question is of backward-compatibilty
> I am trying ubuntu 12.04 and jhbuild and its not loading.

IMHO, we don't need to care backward-compatibility in development branch.
It's my 2 cents.

[Santosh Mahto]

> 
> I tested load and save at different minibrowser

 different minibrowser process?? 
Currently in EFL/Minibrowser CTRL + S (to save) and CTRL + L (to load) is enabled

If its confirmed that mht loading works then we can ignore this patch.

[Ryuan Choi]

(In reply to comment #12)
> > 
> > I tested load and save at different minibrowser
> 
>  different minibrowser process?? 
> Currently in EFL/Minibrowser CTRL + S (to save) and CTRL + L (to load) is enabled
> 
> If its confirmed that mht loading works then we can ignore this patch.

It definitely works for me.

I executed Minibrowser two times.
First one is to test save operation and closed.
Second one is to test load operation and closed.

Second minibrowser completely loads saved page from another web page.

[Santosh Mahto]

As per discussion this is not valid issue as it seems working on latest ubuntu version