Summary: | Update AbstractWorker, Worker and SharedWorker to match the specification | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, darin, esprehn+autocc, haraken | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | https://src.chromium.org/viewvc/blink?revision=152723&view=revision | ||||||
Attachments: |
|
Description
Chris Dumez
2013-06-24 05:09:43 PDT
Created attachment 205287 [details]
Patch
Comment on attachment 205287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review > Source/WebCore/workers/AbstractWorker.idl:-36 > - CustomToJSObject, Why can you remove this? Comment on attachment 205287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review >> Source/WebCore/workers/AbstractWorker.idl:-36 >> - CustomToJSObject, > > Why can you remove this? This basically declares the following in JSAbstractWorker.h but don't generate its implementation in JSAbstractWorker.cpp: JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, AbstractWorker*); It can be removed for 2 reasons: - Its implementation is not provided anywhere and it likely build only because it is not used. - Now that AbstractWorker acts as a partial interface, JSAbstractWorker.* are now empty anyway so this attribute would have no impact whatsoever. Comment on attachment 205287 [details]
Patch
Makes sense.
Comment on attachment 205287 [details] Patch Clearing flags on attachment: 205287 Committed r151956: <http://trac.webkit.org/changeset/151956> All reviewed patches have been landed. Closing bug. |