Bug 117930

Summary: Update AbstractWorker, Worker and SharedWorker to match the specification
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, esprehn+autocc, haraken
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://src.chromium.org/viewvc/blink?revision=152723&view=revision
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-06-24 05:09:43 PDT
Update AbstractWorker, Worker and SharedWorker to match the spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker Worker and SharedWorker should no longer inherit from AbstractWorker. Web IDL 'implements' statements should be used instead. Worker and SharedWorker can now inherit from EventTarget as per the specification.
Attachments
Patch (3.20 KB, patch)
2013-06-24 05:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-06-24 05:19:19 PDT
Created attachment 205287 [details] Patch
Kentaro Hara
Comment 2 2013-06-24 06:40:19 PDT
Comment on attachment 205287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review > Source/WebCore/workers/AbstractWorker.idl:-36 > - CustomToJSObject, Why can you remove this?
Chris Dumez
Comment 3 2013-06-24 07:03:21 PDT
Comment on attachment 205287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review >> Source/WebCore/workers/AbstractWorker.idl:-36 >> - CustomToJSObject, > > Why can you remove this? This basically declares the following in JSAbstractWorker.h but don't generate its implementation in JSAbstractWorker.cpp: JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, AbstractWorker*); It can be removed for 2 reasons: - Its implementation is not provided anywhere and it likely build only because it is not used. - Now that AbstractWorker acts as a partial interface, JSAbstractWorker.* are now empty anyway so this attribute would have no impact whatsoever.
Kentaro Hara
Comment 4 2013-06-24 07:48:32 PDT
Comment on attachment 205287 [details] Patch Makes sense.
WebKit Commit Bot
Comment 5 2013-06-24 23:28:28 PDT
Comment on attachment 205287 [details] Patch Clearing flags on attachment: 205287 Committed r151956: <http://trac.webkit.org/changeset/151956>
WebKit Commit Bot
Comment 6 2013-06-24 23:28:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.