Bug 117913

Summary: Refactor line-break checking in RenderLineBlockLayout::nextSegmentBreak
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: Robert Hogan <robert>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, esprehn+autocc, glenn, mmaxfield, robert, simon.fraser, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from APPLE-EWS-3 for win-future
none
Patch none

WebKit Commit Bot
Reported 2013-06-22 15:16:39 PDT
Remove unnecessary check from RenderLineBlockLayout::nextSegmentBreak Requested by rhogan on #webkit.
Attachments
Patch (5.87 KB, patch)
2013-06-23 02:16 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from APPLE-EWS-3 for win-future (808.67 KB, application/zip)
2013-06-23 07:38 PDT, Build Bot 		no flags
Details
Patch (4.13 KB, patch)
2013-07-04 10:41 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2013-06-23 02:16:35 PDT
Created attachment 205266 [details] Patch
Build Bot
Comment 2 2013-06-23 07:38:22 PDT
Comment on attachment 205266 [details] Patch Attachment 205266 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/978166 New failing tests: media/video-frame-accurate-seek.html
Build Bot
Comment 3 2013-06-23 07:38:23 PDT
Created attachment 205269 [details] Archive of layout-test-results from APPLE-EWS-3 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-3 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Robert Hogan
Comment 4 2013-07-04 10:41:58 PDT
Created attachment 206102 [details] Patch
Ahmad Saleem
Comment 5 2022-09-10 15:41:29 PDT
Is this something needed now? Thanks!
Alexey Proskuryakov
Comment 6 2022-09-11 13:25:49 PDT
A refactoring patch that is this old is exceedingly unlikely to apply at this point.
Note You need to log in before you can comment on or make changes to this bug.