| Summary: | "Refactor adding a line break" | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> | ||||||||
| Component: | New Bugs | Assignee: | Robert Hogan <robert> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | esprehn+autocc, glenn, robert | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
WebKit Commit Bot
2013-06-22 02:58:18 PDT
Created attachment 205243 [details]
Patch
Comment on attachment 205243 [details] Patch Attachment 205243 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/971116 New failing tests: fast/media/mq-transform-03.html fast/forms/search-event-delay.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html Created attachment 205251 [details]
Archive of layout-test-results from APPLE-EWS-4 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-4 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment on attachment 205243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205243&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2866 > +static inline void addLineBreak(LineWidth& width, InlineIterator& lBreak, RenderObject* object, unsigned offset = 0, int nextBreak = -1) I feel like this function name is too generic. commitLineBreakAtCurrentWidth? breakLineAtCurrentWidth or commitCurrentWidthAsLineBreak? Created attachment 205312 [details]
Patch
Comment on attachment 205312 [details] Patch Clearing flags on attachment: 205312 Committed r151922: <http://trac.webkit.org/changeset/151922> All reviewed patches have been landed. Closing bug. |