Bug 117901

Summary: AX: Make more tests usable on both Windows and Mac
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: AccessibilityAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, benjamin, bfulgham, buildbot, cfleizach, commit-queue, dmazzoni, jdiggs, mario, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Revised to correct Mac EWS error. cfleizach: review+

Brent Fulgham
Reported 2013-06-21 17:59:28 PDT
Several of the Accessibility tests use Mac-specific output. By switching from specific text tokens to our standard layout test text comparison, we can use a single test for both platforms.
Attachments
Patch (27.86 KB, patch)
2013-06-24 11:00 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (495.66 KB, application/zip)
2013-06-24 11:39 PDT, Build Bot 		no flags
Details
Revised to correct Mac EWS error. (29.39 KB, patch)
2013-06-24 11:48 PDT, Brent Fulgham 		cfleizach: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-06-24 11:00:13 PDT
Created attachment 205310 [details] Patch
Radar WebKit Bug Importer
Comment 2 2013-06-24 11:00:50 PDT
<rdar://problem/14248148>
Build Bot
Comment 3 2013-06-24 11:39:28 PDT
Comment on attachment 205310 [details] Patch Attachment 205310 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/847502 New failing tests: accessibility/aria-labelledby-overrides-label.html accessibility/aria-tab-roles.html
Build Bot
Comment 4 2013-06-24 11:39:30 PDT
Created attachment 205314 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Brent Fulgham
Comment 5 2013-06-24 11:48:20 PDT
Created attachment 205315 [details] Revised to correct Mac EWS error.
chris fleizach
Comment 6 2013-06-24 11:50:32 PDT
Comment on attachment 205315 [details] Revised to correct Mac EWS error. great!
Brent Fulgham
Comment 7 2013-06-24 13:47:44 PDT
Committed r151924: <http://trac.webkit.org/changeset/151924>
Benjamin Poulain
Comment 8 2013-06-24 19:25:26 PDT
accessibility/aria-tab-roles.html fails on all Mac bots since this landed: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=aria-tab-roles.html Can you please have a look?
Brent Fulgham
Comment 9 2013-06-24 21:09:46 PDT
(In reply to comment #8) > accessibility/aria-tab-roles.html fails on all Mac bots since this landed: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=aria-tab-roles.html > > Can you please have a look? I neglected to update the expected output on the Mac. Committed r151953: <http://trac.webkit.org/changeset/151953>
Note You need to log in before you can comment on or make changes to this bug.