Bug 11790

Summary: No way to initialize ResourceResponse::m_httpHeaderFields
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Minor    
Priority: P3    
Version: 420+   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch mjs: review+

Darin Fisher (:fishd, Google)
Reported 2006-12-08 18:02:01 PST
No way to initialize ResourceResponse::m_httpHeaderFields I propose the addition of a setHTTPHeaderField method.
Attachments
patch (1.72 KB, patch)
2006-12-08 18:18 PST, Darin Fisher (:fishd, Google) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2006-12-08 18:18:31 PST
Created attachment 11783 [details] patch This patch adds the proposed setHTTPHeaderField method. I understand that the mac port gets around this bug by reading fields out of the NSURLResponse, so one could argue that there should be some equivalent 'platform response handle' that is stored on the ResourceResponse, and then the platform ports should implement updateResourceResponse. However, that is overkill for some ports, and since everything else is settable on this class, I think it makes sense to define this method.
Maciej Stachowiak
Comment 2 2006-12-09 14:45:25 PST
Comment on attachment 11783 [details] patch r=me
Alexey Proskuryakov
Comment 3 2006-12-10 02:30:16 PST
Committed revision 18133.
Note You need to log in before you can comment on or make changes to this bug.