Bug 11790 - No way to initialize ResourceResponse::m_httpHeaderFields
Summary: No way to initialize ResourceResponse::m_httpHeaderFields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: PC All
: P3 Minor
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-08 18:02 PST by Darin Fisher (:fishd, Google)
Modified: 2006-12-10 11:43 PST (History)
0 users

See Also:

Attachments
patch (1.72 KB, patch)
2006-12-08 18:18 PST, Darin Fisher (:fishd, Google) 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2006-12-08 18:02:01 PST 
No way to initialize ResourceResponse::m_httpHeaderFields

I propose the addition of a setHTTPHeaderField method.
Comment 1 Darin Fisher (:fishd, Google) 2006-12-08 18:18:31 PST 
Created attachment 11783 [details]
patch

This patch adds the proposed setHTTPHeaderField method.

I understand that the mac port gets around this bug by reading fields out of the NSURLResponse, so one could argue that there should be some equivalent 'platform response handle' that is stored on the ResourceResponse, and then the platform ports should implement updateResourceResponse.  However, that is overkill for some ports, and since everything else is settable on this class, I think it makes sense to define this method.
Comment 2 Maciej Stachowiak 2006-12-09 14:45:25 PST 
Comment on attachment 11783 [details]
patch

r=me
Comment 3 Alexey Proskuryakov 2006-12-10 02:30:16 PST 
Committed revision 18133.