Bug 117894

Summary: GraphicsContext3D including GraphicsContext3DNEON
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2013-06-21 14:23:08 PDT
Source/WebCore/platform/graphics/GraphicsContext3D.cpp's #including GraphicsContext3DNEON.h causes compiler errors on Windows when enabling WebGL. The header itself is protected with #if HAVE(ARM_NEON_INTRINSICS) and everything in GraphicsContext3D that uses it is also protected with the macro, so I suggest the #include also be protected by this macro.
Attachments
Patch (1.39 KB, patch)
2013-06-21 14:30 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-06-21 14:30:24 PDT
Created attachment 205218 [details] Patch
Brent Fulgham
Comment 2 2013-06-21 14:31:24 PDT
Comment on attachment 205218 [details] Patch Looks fine. I'm not sure any of the build bots will verify the Neon stuff is ok...
WebKit Commit Bot
Comment 3 2013-06-21 14:56:13 PDT
Comment on attachment 205218 [details] Patch Clearing flags on attachment: 205218 Committed r151858: <http://trac.webkit.org/changeset/151858>
WebKit Commit Bot
Comment 4 2013-06-21 14:56:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.