Bug 117884

Summary: Update platform text track menu
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2013-06-21 11:13:58 PDT
Allow a text track menu implemented by the platform media player to have "Off" and "Auto" menu items.
Attachments
Proposed patch (4.56 KB, patch)
2013-06-21 11:24 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-06-21 11:24:58 PDT
Created attachment 205203 [details] Proposed patch
Jer Noble
Comment 2 2013-06-21 13:00:47 PDT
Comment on attachment 205203 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=205203&action=review > Source/WebCore/platform/graphics/PlatformTextTrack.h:66 > - static PassRefPtr<PlatformTextTrack> create(PlatformTextTrackClient* client, const String& label, const String& language, TrackKind kind, TrackType type) > + static PassRefPtr<PlatformTextTrack> create(PlatformTextTrackClient* client, const String& label, const String& language, TrackKind kind, TrackType type, int uniqueId) > { > - return adoptRef(new PlatformTextTrack(client, label, language, kind, type)); > + return adoptRef(new PlatformTextTrack(client, label, language, kind, type, uniqueId)); > } This will break the call point in TextTrack.cpp - TextTrack::platformTextTrack(), which does not pass in a uniqueId. Please update that call before you land.
Eric Carlson
Comment 3 2013-06-21 13:41:18 PDT
https://trac.webkit.org/r151853
Note You need to log in before you can comment on or make changes to this bug.