Bug 117874

Summary: HTMLMediaElement should inherit from MediaPlayerClient privately
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: MediaAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 117880    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Description Allan Sandfeld Jensen 2013-06-21 06:27:13 PDT 
HTMLMediaElement was stuck with public inheritance from MediaPlayerClient due to the Chromium port. This can now be fixed to a private inheritance.
Comment 1 Allan Sandfeld Jensen 2013-06-21 06:30:10 PDT 
Created attachment 205176 [details]
Patch
Comment 2 Andreas Kling 2013-06-21 08:36:44 PDT 
Comment on attachment 205176 [details]
Patch

Sweet fix!
Comment 3 Allan Sandfeld Jensen 2013-06-21 09:02:18 PDT 
Comment on attachment 205176 [details]
Patch

Clearing flags on attachment: 205176

Committed r151838: <http://trac.webkit.org/changeset/151838>
Comment 4 Allan Sandfeld Jensen 2013-06-21 09:02:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2013-06-21 09:46:07 PDT 
Re-opened since this is blocked by bug 117880
Comment 6 Allan Sandfeld Jensen 2013-06-24 02:50:14 PDT 
Created attachment 205280 [details]
Patch

Now also fixed MediaPlayerPrivateQt
Comment 7 Allan Sandfeld Jensen 2013-06-25 02:00:53 PDT 
Committed r151958: <http://trac.webkit.org/changeset/151958>