Bug 117864

Summary: An element with -webkit-user-select: all should be selected on single click
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, enrica, sam, syoichi, webkit-ews
Priority: P2 Keywords: InRadar, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Fixes the bug
none
Fixed non-mac builds
darin: review+, darin: commit-queue-
Archive of layout-test-results from APPLE-EWS-5 for win-future none

Description Ryosuke Niwa 2013-06-20 22:09:58 PDT 
An user should be able to select an element with -webkit-user-select: all with a single click.
Comment 1 Ryosuke Niwa 2013-06-20 22:16:00 PDT 
<rdar://problem/13488092>
Comment 2 Ryosuke Niwa 2013-06-20 22:22:10 PDT 
Created attachment 205148 [details]
Fixes the bug
Comment 3 Early Warning System Bot 2013-06-20 22:26:42 PDT 
Comment on attachment 205148 [details]
Fixes the bug

Attachment 205148 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/960017
Comment 4 Early Warning System Bot 2013-06-20 22:28:01 PDT 
Comment on attachment 205148 [details]
Fixes the bug

Attachment 205148 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/906788
Comment 5 Ryosuke Niwa 2013-06-20 22:31:30 PDT 
Created attachment 205149 [details]
Fixes the bug
Comment 6 Ryosuke Niwa 2013-06-20 22:32:52 PDT 
Created attachment 205150 [details]
Fixed non-mac builds
Comment 7 Build Bot 2013-06-21 22:47:31 PDT 
Comment on attachment 205150 [details]
Fixed non-mac builds

Attachment 205150 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/898782

New failing tests:
editing/selection/user-select-all-with-single-click.html
editing/selection/user-select-all-image-with-single-click.html
Comment 8 Build Bot 2013-06-21 22:47:33 PDT 
Created attachment 205234 [details]
Archive of layout-test-results from APPLE-EWS-5 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-5  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 9 Darin Adler 2013-06-28 16:39:13 PDT 
Comment on attachment 205150 [details]
Fixed non-mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=205150&action=review

> Source/WebCore/page/EventHandler.cpp:647
> +#if ENABLE(USERSELECT_ALL)
> +    return node->canStartSelection() || Position::rootUserSelectAllForNode(node);
> +#else
> +    return node->canStartSelection();
> +#endif

Slightly nicer to refactor so we don’t repeat canStartSelection twice.
Comment 10 Ryosuke Niwa 2013-06-28 17:09:40 PDT 
Committed r152198: <http://trac.webkit.org/changeset/152198>