Bug 117864 – An element with -webkit-user-select: all should be selected on single click

• Component: UI Events
• Status: RESOLVED FIXED

[Ryosuke Niwa]

An user should be able to select an element with -webkit-user-select: all with a single click.

[Ryosuke Niwa]

<rdar://problem/13488092>

[Ryosuke Niwa]

Created attachment 205148 [details]
Fixes the bug

[Early Warning System Bot]

Comment on attachment 205148 [details]
Fixes the bug

Attachment 205148 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/960017

[Early Warning System Bot]

Comment on attachment 205148 [details]
Fixes the bug

Attachment 205148 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/906788

[Ryosuke Niwa]

Created attachment 205149 [details]
Fixes the bug

[Ryosuke Niwa]

Created attachment 205150 [details]
Fixed non-mac builds

[Build Bot]

Comment on attachment 205150 [details]
Fixed non-mac builds

Attachment 205150 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/898782

New failing tests:
editing/selection/user-select-all-with-single-click.html
editing/selection/user-select-all-image-with-single-click.html

[Build Bot]

Created attachment 205234 [details]
Archive of layout-test-results from APPLE-EWS-5 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-5  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Darin Adler]

Comment on attachment 205150 [details]
Fixed non-mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=205150&action=review

> Source/WebCore/page/EventHandler.cpp:647
> +#if ENABLE(USERSELECT_ALL)
> +    return node->canStartSelection() || Position::rootUserSelectAllForNode(node);
> +#else
> +    return node->canStartSelection();
> +#endif

Slightly nicer to refactor so we don’t repeat canStartSelection twice.

[Ryosuke Niwa]

Committed r152198: <http://trac.webkit.org/changeset/152198>