Bug 117858

Summary: [CMAKE][EFL] Enable DOM4 Events Constructor
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2013-06-20 18:25:36 PDT
Patch will be added.
Attachments
Patch (6.26 KB, patch)
2013-06-20 18:54 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-06-20 18:54:52 PDT
Created attachment 205135 [details] Patch
Laszlo Gombos
Comment 2 2013-06-20 19:12:51 PDT
Comment on attachment 205135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205135&action=review r=me. > Source/cmake/WebKitFeatures.cmake:50 > + WEBKIT_OPTION_DEFINE(ENABLE_DOM4_EVENTS_CONSTRUCTOR "Expose DOM4 Events constructors" OFF) Nit: "Toggle DOM4 Events constructor" to be consistent.
Ryuan Choi
Comment 3 2013-06-20 19:27:22 PDT
Committed r151815: <http://trac.webkit.org/changeset/151815>
Ryuan Choi
Comment 4 2013-06-20 19:27:58 PDT
Comment on attachment 205135 [details] Patch Thank you. I landed manually after fixed like you suggested.
Note You need to log in before you can comment on or make changes to this bug.