Bug 117854

Summary: Refining the StackBounds computation for Windows
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, paroga, philn, spenap, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
eflews.bot: commit-queue-
patch #2 none

Description Mark Lam 2013-06-20 17:13:06 PDT 
For Windows, the end of the stack should be at the AllocationBase of the stack's reserved address range.  The end of the useable memory in the stack should be at the end of the address range minus the size of the stack guard page.
Comment 1 Mark Lam 2013-06-20 17:15:31 PDT 
Created attachment 205130 [details]
the patch
Comment 2 EFL EWS Bot 2013-06-20 17:17:53 PDT 
Comment on attachment 205130 [details]
the patch

Attachment 205130 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/857694
Comment 3 Mark Lam 2013-06-20 17:41:00 PDT 
Created attachment 205133 [details]
patch #2
Comment 4 Brent Fulgham 2013-06-20 19:27:16 PDT 
Comment on attachment 205133 [details]
patch #2

Nice simplification! R=me.
Comment 5 WebKit Commit Bot 2013-06-20 19:49:47 PDT 
Comment on attachment 205133 [details]
patch #2

Clearing flags on attachment: 205133

Committed r151817: <http://trac.webkit.org/changeset/151817>
Comment 6 WebKit Commit Bot 2013-06-20 19:49:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Pena 2013-08-20 01:49:19 PDT 
Committed r154318: <http://trac.webkit.org/changeset/154318>