Bug 117854

Summary: Refining the StackBounds computation for Windows
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, paroga, philn, spena, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
eflews.bot: commit-queue-
patch #2 none

Mark Lam
Reported 2013-06-20 17:13:06 PDT
For Windows, the end of the stack should be at the AllocationBase of the stack's reserved address range. The end of the useable memory in the stack should be at the end of the address range minus the size of the stack guard page.
Attachments
the patch (4.57 KB, patch)
2013-06-20 17:15 PDT, Mark Lam
eflews.bot: commit-queue-
patch #2 (4.61 KB, patch)
2013-06-20 17:41 PDT, Mark Lam
no flags
Mark Lam
Comment 1 2013-06-20 17:15:31 PDT
Created attachment 205130 [details] the patch
EFL EWS Bot
Comment 2 2013-06-20 17:17:53 PDT
Mark Lam
Comment 3 2013-06-20 17:41:00 PDT
Created attachment 205133 [details] patch #2
Brent Fulgham
Comment 4 2013-06-20 19:27:16 PDT
Comment on attachment 205133 [details] patch #2 Nice simplification! R=me.
WebKit Commit Bot
Comment 5 2013-06-20 19:49:47 PDT
Comment on attachment 205133 [details] patch #2 Clearing flags on attachment: 205133 Committed r151817: <http://trac.webkit.org/changeset/151817>
WebKit Commit Bot
Comment 6 2013-06-20 19:49:50 PDT
All reviewed patches have been landed. Closing bug.
Simon Pena
Comment 7 2013-08-20 01:49:19 PDT
Note You need to log in before you can comment on or make changes to this bug.