Bug 117830

Summary: HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: Web Template FrameworkAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, buildbot, cmarcelo, commit-queue, darin, d-r, esprehn+autocc, fmalita, kangil.han, kling, pdr, rniwa, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
patch v2 none

Mikhail Pozdnyakov
Reported 2013-06-20 05:47:08 PDT
We should reverse the order of the template arguments at alternate 'find', 'contains' and 'add' HashSet methods so that callers can just pass the translator and let the compiler deduce T.
Attachments
patch (54.23 KB, patch)
2013-06-20 06:41 PDT, Mikhail Pozdnyakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
patch v2 (55.08 KB, patch)
2013-06-20 07:29 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2013-06-20 06:41:00 PDT
Created attachment 205082 [details] patch
Build Bot
Comment 2 2013-06-20 07:18:34 PDT
Comment on attachment 205082 [details] patch Attachment 205082 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/927054
Mikhail Pozdnyakov
Comment 3 2013-06-20 07:29:48 PDT
Created attachment 205089 [details] patch v2 fix compilation error on MAC
WebKit Commit Bot
Comment 4 2013-06-20 14:10:22 PDT
Comment on attachment 205089 [details] patch v2 Clearing flags on attachment: 205089 Committed r151800: <http://trac.webkit.org/changeset/151800>
WebKit Commit Bot
Comment 5 2013-06-20 14:10:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.