Bug 117820

Summary:

The order of the generated supplemental code is not guaranteed

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, darin, haraken, laszlo.gombos

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

117785

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2013-06-19 22:15:48 PDT

The order of the generated supplemental code (partial interfaces and implements statements) is not guaranteed. This causes the bindings tests to sometimes fail because the code is generated in a different order.

Comment 1 Kentaro Hara 2013-06-19 22:19:00 PDT

ah, good point. I remembered that I spent one day and noticed this issue when I implemented [Supplemental] for GObject build bots...

Comment 2 Chris Dumez 2013-06-19 22:19:49 PDT

Created attachment 205057 [details]
Patch

Comment 3 WebKit Commit Bot 2013-06-19 22:45:06 PDT

Comment on attachment 205057 [details]
Patch

Clearing flags on attachment: 205057

Committed r151771: <http://trac.webkit.org/changeset/151771>

Comment 4 WebKit Commit Bot 2013-06-19 22:45:08 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Benjamin Poulain 2013-06-20 09:09:13 PDT

Thanks!
All bots are green.