Bug 117820 - The order of the generated supplemental code is not guaranteed
Summary: The order of the generated supplemental code is not guaranteed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 117785
  Show dependency treegraph
 
Reported: 2013-06-19 22:15 PDT by Chris Dumez
Modified: 2013-06-20 09:09 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2013-06-19 22:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-19 22:15:48 PDT
The order of the generated supplemental code (partial interfaces and implements statements) is not guaranteed. This causes the bindings tests to sometimes fail because the code is generated in a different order.
Comment 1 Kentaro Hara 2013-06-19 22:19:00 PDT
ah, good point. I remembered that I spent one day and noticed this issue when I implemented [Supplemental] for GObject build bots...
Comment 2 Chris Dumez 2013-06-19 22:19:49 PDT
Created attachment 205057 [details]
Patch
Comment 3 WebKit Commit Bot 2013-06-19 22:45:06 PDT
Comment on attachment 205057 [details]
Patch

Clearing flags on attachment: 205057

Committed r151771: <http://trac.webkit.org/changeset/151771>
Comment 4 WebKit Commit Bot 2013-06-19 22:45:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Benjamin Poulain 2013-06-20 09:09:13 PDT
Thanks!
All bots are green.