|Summary:||WebGL files not included in Windows build|
|Product:||WebKit||Reporter:||Alex Christensen <achristensen>|
|Version:||528+ (Nightly build)|
|Bug Depends on:||117821|
Description Alex Christensen 2013-06-19 15:36:37 PDT
There are many WebGL source files in these directories that are protected by #if ENABLE(WEBGL) or #if USE(3D_GRAPHICS), so adding them will not break any existing build systems. Source/WebCore/platform/graphics Source/WebCore/platform/graphics/gpu Source/WebCore/platform/graphics/opengl Source/WebCore/html/canvas
Comment 3 WebKit Commit Bot 2013-06-19 22:06:25 PDT
Comment on attachment 205034 [details] Patch Clearing flags on attachment: 205034 Committed r151769: <http://trac.webkit.org/changeset/151769>
Comment 4 WebKit Commit Bot 2013-06-19 22:06:27 PDT
All reviewed patches have been landed. Closing bug.
Comment 6 Brent Fulgham 2013-06-19 22:46:35 PDT
(In reply to comment #0) > There are many WebGL source files in these directories that are protected by #if ENABLE(WEBGL) or #if USE(3D_GRAPHICS), so adding them will not break any existing build systems. > > Source/WebCore/platform/graphics > Source/WebCore/platform/graphics/gpu > Source/WebCore/platform/graphics/opengl > Source/WebCore/html/canvas Our Apple Windows build does enable WebGL, or perhaps turning on accelerated 3D turns it on. Either way, this patch broke the build so I backed it out. The main issue seems to be a lack of GL/glext.h in the Microsoft OpenGL implementation. We might be able to include the Mesa version of the file in WebKitLIbraris/win/include or similar to get things to compile.