Bug 117809

Summary: WebGL files not included in Windows build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, commit-queue
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on: 117821    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2013-06-19 15:36:37 PDT
There are many WebGL source files in these directories that are protected by #if ENABLE(WEBGL) or #if USE(3D_GRAPHICS), so adding them will not break any existing build systems. Source/WebCore/platform/graphics Source/WebCore/platform/graphics/gpu Source/WebCore/platform/graphics/opengl Source/WebCore/html/canvas
Attachments
Patch (25.93 KB, patch)
2013-06-19 15:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-06-19 15:40:55 PDT
Created attachment 205034 [details] Patch
Brent Fulgham
Comment 2 2013-06-19 21:41:34 PDT
Comment on attachment 205034 [details] Patch r=me
WebKit Commit Bot
Comment 3 2013-06-19 22:06:25 PDT
Comment on attachment 205034 [details] Patch Clearing flags on attachment: 205034 Committed r151769: <http://trac.webkit.org/changeset/151769>
WebKit Commit Bot
Comment 4 2013-06-19 22:06:27 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5 2013-06-19 22:36:27 PDT
Re-opened since this is blocked by bug 117821
Brent Fulgham
Comment 6 2013-06-19 22:46:35 PDT
(In reply to comment #0) > There are many WebGL source files in these directories that are protected by #if ENABLE(WEBGL) or #if USE(3D_GRAPHICS), so adding them will not break any existing build systems. > > Source/WebCore/platform/graphics > Source/WebCore/platform/graphics/gpu > Source/WebCore/platform/graphics/opengl > Source/WebCore/html/canvas Our Apple Windows build does enable WebGL, or perhaps turning on accelerated 3D turns it on. Either way, this patch broke the build so I backed it out. The main issue seems to be a lack of GL/glext.h in the Microsoft OpenGL implementation. We might be able to include the Mesa version of the file in WebKitLIbraris/win/include or similar to get things to compile.
Alex Christensen
Comment 7 2013-08-20 09:04:48 PDT
r151769
Note You need to log in before you can comment on or make changes to this bug.