| Summary: | WebGL files not included in Windows build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Minor | CC: | bfulgham, commit-queue | ||||
| Priority: | P3 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Bug Depends on: | 117821 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2013-06-19 15:36:37 PDT
Created attachment 205034 [details]
Patch
Comment on attachment 205034 [details]
Patch
r=me
Comment on attachment 205034 [details] Patch Clearing flags on attachment: 205034 Committed r151769: <http://trac.webkit.org/changeset/151769> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 117821 (In reply to comment #0) > There are many WebGL source files in these directories that are protected by #if ENABLE(WEBGL) or #if USE(3D_GRAPHICS), so adding them will not break any existing build systems. > > Source/WebCore/platform/graphics > Source/WebCore/platform/graphics/gpu > Source/WebCore/platform/graphics/opengl > Source/WebCore/html/canvas Our Apple Windows build does enable WebGL, or perhaps turning on accelerated 3D turns it on. Either way, this patch broke the build so I backed it out. The main issue seems to be a lack of GL/glext.h in the Microsoft OpenGL implementation. We might be able to include the Mesa version of the file in WebKitLIbraris/win/include or similar to get things to compile. |