Bug 117805

Summary:

WebGL needs PLATFORM(WIN) to

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

bfulgham, commit-queue, dino, esprehn+autocc

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from APPLE-EWS-6 for win-future	none

Alex Christensen

Reported 2013-06-19 11:43:41 PDT

There are many lists of platforms that include a certain file, need a certain definition, etc. I think it might be better in some cases to specify which platforms do not need a certain definition to make the lists shorter, but for now I'll jump on the band wagon.

Attachments
Patch (5.26 KB, patch) 2013-06-19 11:45 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from APPLE-EWS-6 for win-future (798.66 KB, application/zip) 2013-06-20 01:51 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-06-19 11:45:52 PDT

Created attachment 205024 [details] Patch

Brent Fulgham

Comment 2 2013-06-19 21:03:22 PDT

Comment on attachment 205024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205024&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.h:777 > +#if PLATFORM(GTK) || PLATFORM(EFL) || USE(CAIRO) This might be better as PLATFORM(WIN_CAIRO), since GTK and EFL both USE(CAIRO). Or, we could just make it "#if USE(CAIRO)".

Build Bot

Comment 3 2013-06-20 01:51:41 PDT

Comment on attachment 205024 [details] Patch Attachment 205024 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/934402 New failing tests: fast/frames/seamless/seamless-nested-crash.html

Build Bot

Comment 4 2013-06-20 01:51:42 PDT

Created attachment 205062 [details] Archive of layout-test-results from APPLE-EWS-6 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-6 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

WebKit Commit Bot

Comment 5 2013-06-20 14:37:32 PDT

Comment on attachment 205024 [details] Patch Clearing flags on attachment: 205024 Committed r151805: <http://trac.webkit.org/changeset/151805>

WebKit Commit Bot

Comment 6 2013-06-20 14:37:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.