Bug 117799

Summary: [BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, cgarcia, commit-queue, rwlbuis, xren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jakob Petsovits 2013-06-19 07:55:19 PDT
Discovered by Xuefei Ren.                                                                     
                                                                                                          
If, in rare cases, BackingStorePrivate::renderContents() returns false, the for() loop in render() will take a tile buffer from the surface pool but due to aborting the iteration early, won't put it into the new tile map. In order to prevent losing the buffer, we need to put it back into the surface pool before continuing.

Patch below.
Comment 1 Jakob Petsovits 2013-06-19 07:59:55 PDT
Created attachment 205006 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-19 08:30:47 PDT
Comment on attachment 205006 [details]
Patch

Clearing flags on attachment: 205006

Committed r151735: <http://trac.webkit.org/changeset/151735>
Comment 3 WebKit Commit Bot 2013-06-19 08:30:49 PDT
All reviewed patches have been landed.  Closing bug.