Bug 117796

Summary: [GTK] remove bashism from configure
Product: WebKit Reporter: Antoine Jacoutot <ajacoutot>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Trivial CC: landry, zan
Priority: P3    
Version: 420+   
Hardware: All   
OS: Other   
Attachments:
Description Flags
Patch none

Description Antoine Jacoutot 2013-06-19 06:24:46 PDT
Hi.

Would it be possible to use something like this in the configure script:

-    FREETYPE_CFLAGS+=" $HARFBUZZ_ICU_CFLAGS"
-    FREETYPE_LIBS+=" $HARFBUZZ_ICU_LIBS"
+    FREETYPE_CFLAGS="$FREETYPE_CFLAGS $HARFBUZZ_ICU_CFLAGS"
+    FREETYPE_LIBS="$FREETYPE_LIBS $HARFBUZZ_ICU_LIBS"

On OpenBSD (and other BSDs for that matter), we don't use bash so the current construct breaks.
Using FREETYPE_CFLAGS="$FREETYPE_CFLAGS ..." fixes it for me.

Thanks.
Comment 1 Zan Dobersek 2013-06-20 08:39:20 PDT
Created attachment 205094 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-06-20 11:44:14 PDT
Comment on attachment 205094 [details]
Patch

LGTM!
Comment 3 Zan Dobersek 2013-06-20 12:32:54 PDT
Comment on attachment 205094 [details]
Patch

Clearing flags on attachment: 205094

Committed r151791: <http://trac.webkit.org/changeset/151791>
Comment 4 Zan Dobersek 2013-06-20 12:32:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Zan Dobersek 2013-10-09 23:01:50 PDT
*** Bug 111879 has been marked as a duplicate of this bug. ***