Bug 117768
| Summary: | Refactoring: Use specific element types in RenderTextControl* | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, kling, koivisto, simon.fraser, tkent, zalan |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consder merging https://chromium.googlesource.com/chromium/blink/+/c435d057894aeca6a9343ebd53ff17425f506ce5
Refactoring: Use specific element types in RenderTextControl*.
- RenderTextControl constructor should take HTMLTextFormControlElement
as an argument.
- RenderTextControlSingleLine constructor should take HTMLInputElement
as an argument.
- RenderSearchField constructor should take HTMLInputElement as an
argument.
- RenderTextControlMultiLine constructor should take HTMLTextAreaElement
as an argument.
Also, simplify updateUserModifyProperty by changing an argument from
Node* to HTMLTextFormControlElement*.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Webkit copied CSSPraser from Blink, do we need this anymore? Thanks!
Ahmad Saleem
(In reply to Ahmad Saleem from comment #1)
> Webkit copied CSSPraser from Blink, do we need this anymore? Thanks!
Ignore my comment, realised that the commit link in Comment 0 is incorrect compared to what is asked in this bug.
Alexey Proskuryakov
This is all done in WebKit at this point.