Bug 117765

Summary: Rename functions from Bug 117667 and add safeguards for !ENABLE(VIDEO) platforms
Product: WebKit Reporter: Ruth Fong <ruthiecftg>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kadam, ossy, ruthiecftg, webkit-bug-importer, zarvai
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion
none
Patch beidson: review+, thorton: commit-queue-

Ruth Fong
Reported 2013-06-18 18:00:45 PDT
Tie up loose ends from Bug 117667: - Rename functions getMediaType() to mediaType() - Make it work for !ENABLE(VIDEO) platforms
Attachments
Patch (3.44 KB, patch)
2013-06-18 18:12 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (575.06 KB, application/zip)
2013-06-19 10:56 PDT, WebKit Commit Bot 		no flags
Details
Patch (3.47 KB, patch)
2013-06-19 15:53 PDT, Ruth Fong 		beidson: review+
thorton: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-06-18 18:01:23 PDT
<rdar://problem/14197983>
Ruth Fong
Comment 2 2013-06-18 18:12:15 PDT
Created attachment 204961 [details] Patch
WebKit Commit Bot
Comment 3 2013-06-19 10:56:39 PDT
Comment on attachment 204961 [details] Patch Rejecting attachment 204961 [details] from commit-queue. New failing tests: media/track/media-element-enqueue-event-crash.html Full output: http://webkit-queues.appspot.com/results/942291
WebKit Commit Bot
Comment 4 2013-06-19 10:56:41 PDT
Created attachment 205017 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Ruth Fong
Comment 5 2013-06-19 15:53:55 PDT
Created attachment 205035 [details] Patch
Ruth Fong
Comment 6 2013-06-19 15:58:54 PDT
(In reply to comment #4) > Created an attachment (id=205017) [details] > Archive of layout-test-results from webkit-cq-02 for mac-mountainlion > > The attached test failures were seen while running run-webkit-tests on the commit-queue. > Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3 I ran the specific failing test on Mac OS X 10.8.4 and it ran as expected - not sure if this was an issue with commit-queue.
Ruth Fong
Comment 7 2013-06-19 17:17:30 PDT
Tim Horton landed the patch: http://trac.webkit.org/changeset/151760
Ruth Fong
Comment 8 2013-06-19 17:24:04 PDT
The reason commit-queue was failing is due to an unhandled null case in TextTrackCue::cueIndex(). Bug 117815 is tracking this issue.
Note You need to log in before you can comment on or make changes to this bug.