Bug 117761

Summary: [Windows] AX: Extend notification support
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: AccessibilityAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bfulgham, cfleizach, commit-queue, dmazzoni, esprehn+autocc, jdiggs, kangil.han, mario
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 38882    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2013-06-18 15:38:05 PDT
Continue the IAccessible2 interface support: 1. Hook up some missing Document notification handlers. 2. Provide 'press' implementation in DumpRenderTree so press events can be handled.
Attachments
Patch (9.25 KB, patch)
2013-06-19 09:52 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-06-18 15:40:44 PDT
This is also related to <rdar://problem/9524530>
Brent Fulgham
Comment 2 2013-06-19 09:52:41 PDT
Created attachment 205013 [details] Patch
WebKit Commit Bot
Comment 3 2013-06-19 09:54:00 PDT
Attachment 205013 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/win/AXObjectCacheWin.cpp', u'Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebKit/win/AccessibleDocument.cpp', u'Source/WebKit/win/AccessibleDocument.h', u'Source/WebKit/win/ChangeLog', u'Tools/ChangeLog', u'Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp']" exit_code: 1 Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:81: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 4 2013-06-19 11:08:19 PDT
(In reply to comment #3) > Attachment 205013 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/win/AXObjectCacheWin.cpp', u'Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebKit/win/AccessibleDocument.cpp', u'Source/WebKit/win/AccessibleDocument.h', u'Source/WebKit/win/ChangeLog', u'Tools/ChangeLog', u'Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp']" exit_code: 1 > Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp:33: Alphabetical sorting problem. [build/include_order] [4] > Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:81: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] > Total errors found: 2 in 10 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. To avoid the stylebot warning, I would have to reformat the entire switch statement. I'm ignoring this style suggestion.
Brent Fulgham
Comment 5 2013-06-19 11:46:13 PDT
Comment on attachment 205013 [details] Patch Clearing flags on attachment: 205013 Committed r151745: <http://trac.webkit.org/changeset/151745>
Brent Fulgham
Comment 6 2013-06-19 11:46:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.