Bug 117732

Summary: Move IDL extended attributes to their correct location
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, haraken, jberlin, laszlo.gombos, thorton, timothy
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://src.chromium.org/viewvc/blink?view=rev&revision=148345
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-06-18 03:26:54 PDT
Move IDL extended attributes to their correct location and simplify the IDL parser, similarly to: https://src.chromium.org/viewvc/blink?view=rev&revision=148345
Attachments
Patch (43.02 KB, patch)
2013-06-18 04:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-06-18 04:05:02 PDT
Created attachment 204896 [details] Patch
Kentaro Hara
Comment 2 2013-06-18 04:14:22 PDT
Comment on attachment 204896 [details] Patch LGTM. This might break Safari's internal build, so please contact xenon@ and thorton@ before landing.
Jessie Berlin
Comment 3 2013-06-18 09:07:50 PDT
I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC.
Chris Dumez
Comment 4 2013-06-18 10:00:17 PDT
(In reply to comment #3) > I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC. Sure, will do.
Jessie Berlin
Comment 5 2013-06-18 15:31:59 PDT
(In reply to comment #4) > (In reply to comment #3) > > I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC. > > Sure, will do. You can land this whenever you are ready to, the appropriate changes have already been made in Safari.
WebKit Commit Bot
Comment 6 2013-06-18 18:45:58 PDT
Comment on attachment 204896 [details] Patch Clearing flags on attachment: 204896 Committed r151714: <http://trac.webkit.org/changeset/151714>
WebKit Commit Bot
Comment 7 2013-06-18 18:46:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.