| Summary: | Move IDL extended attributes to their correct location | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, darin, haraken, jberlin, laszlo.gombos, thorton, timothy | ||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://src.chromium.org/viewvc/blink?view=rev&revision=148345 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2013-06-18 03:26:54 PDT
Created attachment 204896 [details]
Patch
Comment on attachment 204896 [details]
Patch
LGTM. This might break Safari's internal build, so please contact xenon@ and thorton@ before landing.
I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC. (In reply to comment #3) > I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC. Sure, will do. (In reply to comment #4) > (In reply to comment #3) > > I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC. > > Sure, will do. You can land this whenever you are ready to, the appropriate changes have already been made in Safari. Comment on attachment 204896 [details] Patch Clearing flags on attachment: 204896 Committed r151714: <http://trac.webkit.org/changeset/151714> All reviewed patches have been landed. Closing bug. |