Bug 117732 - Move IDL extended attributes to their correct location
Summary: Move IDL extended attributes to their correct location
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://src.chromium.org/viewvc/blink...
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-06-18 03:26 PDT by Chris Dumez
Modified: 2013-06-18 18:46 PDT (History)
8 users (show)

See Also:

Attachments
Patch (43.02 KB, patch)
2013-06-18 04:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-18 03:26:54 PDT 
Move IDL extended attributes to their correct location and simplify the IDL parser, similarly to:
https://src.chromium.org/viewvc/blink?view=rev&revision=148345
Comment 1 Chris Dumez 2013-06-18 04:05:02 PDT 
Created attachment 204896 [details]
Patch
Comment 2 Kentaro Hara 2013-06-18 04:14:22 PDT 
Comment on attachment 204896 [details]
Patch

LGTM. This might break Safari's internal build, so please contact xenon@ and thorton@ before landing.
Comment 3 Jessie Berlin 2013-06-18 09:07:50 PDT 
I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC.
Comment 4 Chris Dumez 2013-06-18 10:00:17 PDT 
(In reply to comment #3)
> I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC.

Sure, will do.
Comment 5 Jessie Berlin 2013-06-18 15:31:59 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > I would appreciate if you could give us some notice when you plan to land this, ideally by pinging me (@jessieberlin), @xenon, or @thorton on IRC.
> 
> Sure, will do.

You can land this whenever you are ready to, the appropriate changes have already been made in Safari.
Comment 6 WebKit Commit Bot 2013-06-18 18:45:58 PDT 
Comment on attachment 204896 [details]
Patch

Clearing flags on attachment: 204896

Committed r151714: <http://trac.webkit.org/changeset/151714>
Comment 7 WebKit Commit Bot 2013-06-18 18:46:01 PDT 
All reviewed patches have been landed.  Closing bug.