Summary: | Synthesized vertical italics on rotated glyphs are transformed incorrectly | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||
Component: | Text | Assignee: | Dean Jackson <dino> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit-ews | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Dean Jackson
2013-06-17 22:38:07 PDT
Created attachment 204883 [details]
Patch
Comment on attachment 204883 [details] Patch Attachment 204883 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/937247 Comment on attachment 204883 [details] Patch Attachment 204883 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/884197 Comment on attachment 204883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204883&action=review > Source/WebCore/platform/graphics/FontGlyphs.cpp:207 > + RefPtr<SimpleFontData> nonItalicFontData = data.fontData->nonSyntheticItalicFontData(); > + GlyphPageTreeNode* nonItalicNode = GlyphPageTreeNode::getRootChild(nonItalicFontData.get(), pageNumber); > + GlyphPage* nonItalicPage = nonItalicNode->page(); Nit: these aren't used if page is NULL. (In reply to comment #4) > (From update of attachment 204883 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204883&action=review > > > Source/WebCore/platform/graphics/FontGlyphs.cpp:207 > > + RefPtr<SimpleFontData> nonItalicFontData = data.fontData->nonSyntheticItalicFontData(); > > + GlyphPageTreeNode* nonItalicNode = GlyphPageTreeNode::getRootChild(nonItalicFontData.get(), pageNumber); > > + GlyphPage* nonItalicPage = nonItalicNode->page(); > > Nit: these aren't used if page is NULL. That was a typo. It should have been if (nonItalicPage). Thanks for noticing! Comment on attachment 204883 [details]
Patch
Looks good to me, with the change Eric pointed out. I trust you to fix the 2 qt builds before landing the patch.
Created attachment 204932 [details]
Patch
Committed r151693: <http://trac.webkit.org/changeset/151693> |