Bug 117725 – [Qt][WK2] memory leak in QQuickWebView

• Component: WebKit2
• Status: RESOLVED INVALID

[Sangho Kim]

There are QQuickWebViewExperimental pointer in QQuickWebView.
The constructor of QQuickWebView new QQuickWebViewExperimental. But the destructor doesn't delete this.

[Sangho Kim]

Created attachment 204881 [details]
patch

adding delete clase...

[WebKit Commit Bot]

Comment on attachment 204881 [details]
patch

Rejecting attachment 204881 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Sergio Villar Senin]

Comment on attachment 204881 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204881&action=review

Overall looks good, some Qt reviewer should take a look though. Some nits

> Source/WebKit2/ChangeLog:7
> +

You need to include a short description of the patch here.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:319
> +    if (experimental)

Why if? Isn't it always created?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1057
> +    if (schemeParent)

Same question here about the if.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1059
> +    if (m_test)

Ditto.

[Sangho Kim]

Created attachment 205158 [details]
patch

changed the ChangeLog and delete if phrase.

[Rafael Brandao]

Comment on attachment 204881 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204881&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:320
> +        delete experimental;

If this fix is right, then it seems that you need to use an OwnPtr on QQuickWebViewPrivate rather than a raw pointer.

[Sangho Kim]

Created attachment 205274 [details]
patch

change raw pointer to OwnPtr of QQuickWebViewExperimental

[Sangho Kim]

Please review and commit...

[Anders Carlsson]

Qt has been removed, clearing review flags.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.