Bug 117711

Summary: [CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
Product: WebKit Reporter: Ralph T <ralpht+bugs>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, paroga, rakuco, ralpht+bugs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ralph T
Reported 2013-06-17 11:48:59 PDT
[CMake][CSS Shaders] Conditionally add WebCore files for CSS Shaders to CMakeLists.txt
Attachments
Patch (1.87 KB, patch)
2013-06-17 11:51 PDT, Ralph T 		no flags
DetailsFormatted DiffDiff
Patch (2.72 KB, patch)
2013-06-18 12:27 PDT, Ralph T 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ralph T
Comment 1 2013-06-17 11:51:44 PDT
Created attachment 204845 [details] Patch
Ralph T
Comment 2 2013-06-18 08:19:51 PDT
Comment on attachment 204845 [details] Patch Since all of the files included are guarded with #if ENABLE(CSS_SHADERS) I can just add them to WebCore_SOURCES unconditionally -- I'll submit a new patch that does this later today. Thanks to Patrick Gansterer and Raphael Kubo da Costa for review.
Ralph T
Comment 3 2013-06-18 12:27:44 PDT
Created attachment 204929 [details] Patch
Ralph T
Comment 4 2013-06-18 12:37:32 PDT
New patch adds files to the build unconditionally, since they're all guarded with #if ENABLE(CSS_SHADERS).
Laszlo Gombos
Comment 5 2013-06-20 09:09:56 PDT
Comment on attachment 204929 [details] Patch r=me.
WebKit Commit Bot
Comment 6 2013-06-20 11:08:10 PDT
Comment on attachment 204929 [details] Patch Clearing flags on attachment: 204929 Committed r151784: <http://trac.webkit.org/changeset/151784>
WebKit Commit Bot
Comment 7 2013-06-20 11:08:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.