Bug 117710

Summary: fourthTier: DFG should have switch_char
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
it compiles!
none
the patch
msaboff: review+
patch for landing none

Filip Pizlo
Reported 2013-06-17 11:45:31 PDT
Patch forthcoming.
Attachments
work in progress (15.75 KB, patch)
2013-06-17 11:46 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it compiles! (36.67 KB, patch)
2013-06-17 16:00 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (47.51 KB, patch)
2013-06-18 08:40 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
patch for landing (53.48 KB, patch)
2013-06-18 11:05 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-06-17 11:46:15 PDT
Created attachment 204844 [details] work in progress
Filip Pizlo
Comment 2 2013-06-17 16:00:37 PDT
Created attachment 204863 [details] it compiles!
Filip Pizlo
Comment 3 2013-06-18 08:40:30 PDT
Created attachment 204918 [details] the patch
Michael Saboff
Comment 4 2013-06-18 10:09:09 PDT
Comment on attachment 204918 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204918&action=review > Source/WTF/ChangeLog:11 > + Also made it possible to convert a UChar to a utf8 CString without > + allocating a StringImpl. Since this is only used with dump() methods, why do we care about allocating a StringImpl?
Filip Pizlo
Comment 5 2013-06-18 10:39:34 PDT
(In reply to comment #4) > (From update of attachment 204918 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204918&action=review > > > Source/WTF/ChangeLog:11 > > + Also made it possible to convert a UChar to a utf8 CString without > > + allocating a StringImpl. > > Since this is only used with dump() methods, why do we care about allocating a StringImpl? Because you cannot ref/deref StringImpl's on the compiler thread, which implicitly means you cannot allocate them. That's an important assertion, since StringImpl's aren't thread-safe ref-counted. So we want to keep that assertion; but to keep it, we can't allocate StringImpls in the compiler thread.
Filip Pizlo
Comment 6 2013-06-18 11:05:55 PDT
Created attachment 204925 [details] patch for landing Now including tests.
Filip Pizlo
Comment 7 2013-06-20 10:54:46 PDT
Landed in http://trac.webkit.org/changeset/151781
Note You need to log in before you can comment on or make changes to this bug.