Bug 117698

Summary:

[New multicol] Change test to follow the pattern of the other tests

Product:

WebKit

Reporter:

Mihai Maerean <mmaerean>

Component:

WebCore Misc.

Assignee:

Mihai Maerean <mmaerean>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

116614

Bug Blocks:

Attachments:

Description	Flags
patch	none
patch that integrates the feedback from Zoltan.	none

Mihai Maerean

Reported 2013-06-17 08:37:17 PDT

Change LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html to follow the pattern of the other tests: the expected result is using the old multicol code.

Attachments
patch (2.47 KB, patch) 2013-06-17 08:49 PDT, Mihai Maerean	no flags	Details Formatted Diff Diff
patch that integrates the feedback from Zoltan. (3.79 KB, patch) 2013-06-17 23:56 PDT, Mihai Maerean	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mihai Maerean

Comment 1 2013-06-17 08:49:26 PDT

Created attachment 204826 [details] patch test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/

Zoltan Horvath

Comment 2 2013-06-17 15:38:52 PDT

Comment on attachment 204826 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=204826&action=review > LayoutTests/ChangeLog:3 > + [New multicol] Change test to follow the pattern of the other tests I would call this bug to something like: Turn fast/multicol/newmulticol/direct-child-column-span-all.html into a reftest > LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html:13 > + test passes if it doesn't crash or assert. Since you have a reftest now I would add a small explanation what is happening here (description of http://trac.webkit.org/changeset/150611) and a reference to the original bug where the test has been added (https://bugs.webkit.org/show_bug.cgi?id=116614), so we can easily see what's going on if it fails in the future.

Mihai Maerean

Comment 3 2013-06-17 23:56:36 PDT

Created attachment 204884 [details] patch that integrates the feedback from Zoltan.

WebKit Commit Bot

Comment 4 2013-07-05 03:27:29 PDT

Comment on attachment 204884 [details] patch that integrates the feedback from Zoltan. Clearing flags on attachment: 204884 Committed r152413: <http://trac.webkit.org/changeset/152413>

WebKit Commit Bot

Comment 5 2013-07-05 03:27:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.