Summary: | [Mac] Sort all the Xcode project files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | Tools / Tests | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Darin Adler
2013-06-17 08:05:32 PDT
Created attachment 204824 [details]
Patch
Attachment 204824 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ChangeLog', u'Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj', u'Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebInspectorUI/ChangeLog', u'Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj:458: Missing "developmentRegion = English". [xcodeproj/settings] [5]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 204824 [details] Patch Rejecting attachment 204824 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 204824, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t 4 lines). Hunk #56 succeeded at 7005 (offset 4 lines). Hunk #57 succeeded at 7054 (offset 4 lines). Hunk #58 succeeded at 7083 (offset 4 lines). Hunk #59 succeeded at 7099 (offset 4 lines). Hunk #60 succeeded at 7162 (offset 4 lines). 1 out of 60 hunks FAILED -- saving rejects to file Source/WebKit2/WebKit2.xcodeproj/project.pbxproj.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Anders Carlsson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/942112 Committed r151888: <http://trac.webkit.org/changeset/151888> |