Bug 117685

Summary: Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Gyuyoung Kim
Reported 2013-06-16 18:33:35 PDT
Avoid duplicating hostWindow() call. Merge with https://src.chromium.org/viewvc/blink?view=rev&revision=152490
Attachments
Patch (1.42 KB, patch)
2013-06-16 18:37 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.41 KB, patch)
2013-06-16 20:16 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-06-16 18:37:43 PDT
Created attachment 204794 [details] Patch
Gyuyoung Kim
Comment 2 2013-06-16 18:38:53 PDT
CC'ing Kling. could you take a look at this ?
Andreas Kling
Comment 3 2013-06-16 19:30:20 PDT
Comment on attachment 204794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review r=me > Source/WebCore/ChangeLog:3 > + Minor refactoring with FrameView::InvalidateRect() for hostWindow call The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring." FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()"
Gyuyoung Kim
Comment 4 2013-06-16 20:16:30 PDT
Created attachment 204796 [details] Patch for landing
Gyuyoung Kim
Comment 5 2013-06-16 20:17:37 PDT
(In reply to comment #3) > (From update of attachment 204794 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review > > r=me > > > Source/WebCore/ChangeLog:3 > > + Minor refactoring with FrameView::InvalidateRect() for hostWindow call > > The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring." > FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()" Ok, thanks. I fixed.
WebKit Commit Bot
Comment 6 2013-06-16 20:56:57 PDT
Comment on attachment 204796 [details] Patch for landing Clearing flags on attachment: 204796 Committed r151628: <http://trac.webkit.org/changeset/151628>
WebKit Commit Bot
Comment 7 2013-06-16 20:56:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.