Summary: | Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | New Bugs | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, kling | ||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-06-16 18:33:35 PDT
Created attachment 204794 [details]
Patch
CC'ing Kling. could you take a look at this ? Comment on attachment 204794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review r=me > Source/WebCore/ChangeLog:3 > + Minor refactoring with FrameView::InvalidateRect() for hostWindow call The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring." FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()" Created attachment 204796 [details]
Patch for landing
(In reply to comment #3) > (From update of attachment 204794 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review > > r=me > > > Source/WebCore/ChangeLog:3 > > + Minor refactoring with FrameView::InvalidateRect() for hostWindow call > > The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring." > FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()" Ok, thanks. I fixed. Comment on attachment 204796 [details] Patch for landing Clearing flags on attachment: 204796 Committed r151628: <http://trac.webkit.org/changeset/151628> All reviewed patches have been landed. Closing bug. |