| Summary: | Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | New Bugs | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2013-06-15 17:06:39 PDT
Created attachment 204776 [details]
Patch
Comment on attachment 204776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554 > +#if ENABLE(JIT) > + , m_capabilityLevelState(DFG::CapabilityLevelNotSet) > +#endif Is this related? If not, you should call it out in your changelog or commit it separately. (In reply to comment #2) > (From update of attachment 204776 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review > > > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554 > > +#if ENABLE(JIT) > > + , m_capabilityLevelState(DFG::CapabilityLevelNotSet) > > +#endif > > Is this related? If not, you should call it out in your changelog or commit it separately. No - while messing around with the constructor I realized that this field wasn't being initialized in all constructors. Landed in http://trac.webkit.org/changeset/151618 |