Bug 117676 – Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy

• Component: New Bugs
• Status: RESOLVED FIXED

[Filip Pizlo]

Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy

[Filip Pizlo]

Created attachment 204776 [details]
Patch

[Sam Weinig]

Comment on attachment 204776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554
> +#if ENABLE(JIT)
> +    , m_capabilityLevelState(DFG::CapabilityLevelNotSet)
> +#endif

Is this related?  If not, you should call it out in your changelog or commit it separately.

[Filip Pizlo]

(In reply to comment #2)
> (From update of attachment 204776 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review
> 
> > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554
> > +#if ENABLE(JIT)
> > +    , m_capabilityLevelState(DFG::CapabilityLevelNotSet)
> > +#endif
> 
> Is this related?  If not, you should call it out in your changelog or commit it separately.

No - while messing around with the constructor I realized that this field wasn't being initialized in all constructors.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/151618