Bug 117673

Summary: Move Pasteboard::getStringSelection to Editor, fixing a layering violation
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Darin Adler 2013-06-15 10:27:48 PDT
Move Pasteboard::getStringSelection to Editor, fixing a layering violation
Comment 1 Darin Adler 2013-06-15 10:35:15 PDT
Created attachment 204770 [details]
Comment 2 Build Bot 2013-06-15 10:59:24 PDT
Comment on attachment 204770 [details]

Attachment 204770 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/913116
Comment 3 Darin Adler 2013-06-15 11:03:03 PDT
Created attachment 204772 [details]
Comment 4 Ryosuke Niwa 2013-06-15 11:18:13 PDT
Comment on attachment 204772 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=204772&action=review

> Source/WebCore/editing/mac/EditorMac.mm:278
> +// FIXME: Makes no sense that selectedTextForClipboard always includes alt text, but stringSelectionForPasteboard does not.
> +// This was left in a bad state when selectedTextForClipboard was added. Need to look over clients and fix this.

There is some discussion in https://bugs.webkit.org/show_bug.cgi?id=11200 but the idea is that we don't want to include alt text when we're exposing it to Mac services.
I think the one that doesn't include alt should be postfixed with "ForClipboard".
Comment 5 WebKit Commit Bot 2013-06-15 19:21:41 PDT
Comment on attachment 204772 [details]

Clearing flags on attachment: 204772

Committed r151620: <http://trac.webkit.org/changeset/151620>
Comment 6 WebKit Commit Bot 2013-06-15 19:21:44 PDT
All reviewed patches have been landed.  Closing bug.