Bug 117671

Summary: Initialize AtomicStringTable in WTFThreadData's constructor
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue, darin, eflews.bot, ggaren, gtk-ews, gyuyoung.kim, gyuyoung.kim, philn, rakuco, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Fixed builds ggaren: review+

Ryosuke Niwa
Reported 2013-06-14 22:44:58 PDT
Initialize AtomicStringTable in WTFThreadData's constructor
Attachments
Cleanup (12.71 KB, patch)
2013-06-14 22:46 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed builds (15.78 KB, patch)
2013-06-14 23:14 PDT, Ryosuke Niwa 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-06-14 22:46:49 PDT
Created attachment 204758 [details] Cleanup
Ryosuke Niwa
Comment 2 2013-06-14 22:47:54 PDT
This addresses a comment added to stringTable() in http://trac.webkit.org/changeset/57829.
EFL EWS Bot
Comment 3 2013-06-14 22:50:49 PDT
Comment on attachment 204758 [details] Cleanup Attachment 204758 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/912040
Early Warning System Bot
Comment 4 2013-06-14 22:51:36 PDT
Comment on attachment 204758 [details] Cleanup Attachment 204758 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/904099
Early Warning System Bot
Comment 5 2013-06-14 22:53:21 PDT
Comment on attachment 204758 [details] Cleanup Attachment 204758 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/916055
kov's GTK+ EWS bot
Comment 6 2013-06-14 22:53:22 PDT
Comment on attachment 204758 [details] Cleanup Attachment 204758 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/909053
EFL EWS Bot
Comment 7 2013-06-14 22:53:49 PDT
Comment on attachment 204758 [details] Cleanup Attachment 204758 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/930052
Ryosuke Niwa
Comment 8 2013-06-14 23:14:35 PDT
Created attachment 204760 [details] Fixed builds
Darin Adler
Comment 9 2013-06-15 11:00:26 PDT
Comment on attachment 204760 [details] Fixed builds Why is this a class? We should just have HashSet<StringImpl*> in the thread data. We can have create and destroy functions, but no need to have this be a class.
Ryosuke Niwa
Comment 10 2013-06-15 11:14:07 PDT
(In reply to comment #9) > (From update of attachment 204760 [details]) > Why is this a class? We should just have HashSet<StringImpl*> in the thread data. We can have create and destroy functions, but no need to have this be a class. I think the idea is to add, remove, etc... to this class to eventually encapsulate m_table. IdentifierTable does this already: http://trac.webkit.org/browser/trunk/Source/WTF/wtf/WTFThreadData.h#L42
Geoffrey Garen
Comment 11 2013-06-17 13:53:40 PDT
Comment on attachment 204760 [details] Fixed builds View in context: https://bugs.webkit.org/attachment.cgi?id=204760&action=review r=me > Source/WTF/ChangeLog:8 > + Extracted AtomicStringTable from AtomicString.cpp into AtomicStringTable.h.cpp .h.cpp :(.
Ryosuke Niwa
Comment 12 2013-06-17 18:08:47 PDT
Committed r151663: <http://trac.webkit.org/changeset/151663>
Note You need to log in before you can comment on or make changes to this bug.