Summary: | [CSS Shapes] Consider bottom borders when calculating the position of the overflow | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||
Component: | CSS | Assignee: | Zoltan Horvath <zoltan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, WebkitBugTracker | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 89256 | ||||||
Attachments: |
|
Description
Zoltan Horvath
2013-06-14 16:04:26 PDT
Created attachment 204750 [details]
proposed patch
Comment on attachment 204750 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=204750&action=review Looks good. > LayoutTests/ChangeLog:9 > + not below the border box. The behavior was correct for flow thread cases, but not for not flow thread cases. I refactored nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :) > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1657 > + if (lineOverFlowsFromShapeInside) nit: Let's keep the Overflow with small caps, just to be consistent with the function name. (In reply to comment #2) > nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :) Fixed. > nit: Let's keep the Overflow with small caps, just to be consistent with the function name. Fixed. Thanks for the review. Landed in: http://trac.webkit.org/changeset/151652 |