Bug 117663

Summary: [CSS Shapes] Consider bottom borders when calculating the position of the overflow
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256    
Attachments:
Description Flags
proposed patch achicu: review+

Zoltan Horvath
Reported 2013-06-14 16:04:26 PDT
We need to push the overflow below the content box, not below the border box. The behavior was correct for flow thread cases, but not for simple cases. I refactored the overflow handling to a new helper function.
Attachments
proposed patch (20.08 KB, patch)
2013-06-14 17:14 PDT, Zoltan Horvath 		achicu: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-06-14 17:14:21 PDT
Created attachment 204750 [details] proposed patch
Alexandru Chiculita
Comment 2 2013-06-17 11:55:25 PDT
Comment on attachment 204750 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=204750&action=review Looks good. > LayoutTests/ChangeLog:9 > + not below the border box. The behavior was correct for flow thread cases, but not for not flow thread cases. I refactored nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :) > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1657 > + if (lineOverFlowsFromShapeInside) nit: Let's keep the Overflow with small caps, just to be consistent with the function name.
Zoltan Horvath
Comment 3 2013-06-17 13:25:43 PDT
(In reply to comment #2) > nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :) Fixed. > nit: Let's keep the Overflow with small caps, just to be consistent with the function name. Fixed. Thanks for the review. Landed in: http://trac.webkit.org/changeset/151652
Note You need to log in before you can comment on or make changes to this bug.