Bug 117650

Summary: <meter> element AXValue is listed as a writable value
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109023    
Bug Blocks:    
Attachments:
Description Flags
test case
none
Patch.
none
Patch. none

James Craig
Reported 2013-06-14 12:45:15 PDT
<meter> element AXValue is listed as a writable value related to bug 109023
Attachments
test case (369 bytes, text/html)
2013-06-14 12:45 PDT, James Craig 		no flags
Details
Patch. (3.82 KB, patch)
2013-09-12 11:18 PDT, Samuel White 		no flags
DetailsFormatted DiffDiff
Patch. (3.75 KB, patch)
2013-09-12 13:47 PDT, Samuel White 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Craig
Comment 1 2013-06-14 12:45:49 PDT
Created attachment 204730 [details] test case
James Craig
Comment 2 2013-06-14 12:46:34 PDT
<rdar://problem/14159536>
Samuel White
Comment 3 2013-09-12 11:18:49 PDT
Created attachment 211450 [details] Patch. Changed writability of meter element AXValue to false.
chris fleizach
Comment 4 2013-09-12 11:42:40 PDT
Comment on attachment 211450 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=211450&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2679 > + if (!isMeter() && (isProgressIndicator() || isSlider())) this would *might* still allow a meter element to be writable isReadOnly returned false You might want to do if (isMeter()) return false; which will keep the logic simple
Samuel White
Comment 5 2013-09-12 13:47:33 PDT
Created attachment 211468 [details] Patch. I didn't worry about placing the isMeter check before the aria-readonly logic because those checks shouldn't apply given the role. But, I see your point about avoiding a potential edge case. Thanks for the help.
WebKit Commit Bot
Comment 6 2013-09-12 15:40:46 PDT
Comment on attachment 211468 [details] Patch. Clearing flags on attachment: 211468 Committed r155653: <http://trac.webkit.org/changeset/155653>
WebKit Commit Bot
Comment 7 2013-09-12 15:40:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.