Summary: | [GTK][WK1] Missing symbols | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2013-06-14 00:16:38 PDT
(In reply to comment #0) > Compiling only WK1 like it's doing by the bots is not working due to missing symbols: > Tools/Scripts/build-webkit --release --gtk --no-webkit2 By bots I mean the GTK+ WK1 EWS. Created attachment 204678 [details]
Patch
Created attachment 204679 [details]
Patch
WK1 build fails without this symbols while WK2 build works properly. As expxpected WK1 + WK2 build fails too.
Comment on attachment 204679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204679&action=review > ChangeLog:9 > + * Source/autotools/symbols.filter: Added missing symbols when compiling > + only WK1. This comment is confusing, because this file is common for wk1 and wk2, I would say something like: Added missing symbols *needed* when compiling WK1. Removing also the "only" because they are also needed when building both wk1 and wk2. Created attachment 204680 [details]
Patch
Fix ChangeLog message.
Comment on attachment 204680 [details] Patch Clearing flags on attachment: 204680 Committed r151583: <http://trac.webkit.org/changeset/151583> All reviewed patches have been landed. Closing bug. |