Bug 117629

Summary: [GTK][WK1] Missing symbols
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2013-06-14 00:16:38 PDT
Compiling only WK1 like it's doing by the bots is not working due to missing symbols: Tools/Scripts/build-webkit --release --gtk --no-webkit2 ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore41setJSTypeConversionsTestEnforceRangeOctetEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore7toUInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE' ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore29setJSTypeConversionsTestOctetEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore7toUInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE' ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore40setJSTypeConversionsTestEnforceRangeByteEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore6toInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE' ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore28setJSTypeConversionsTestByteEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore6toInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE'
Attachments
Patch (1.33 KB, patch)
2013-06-14 00:20 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2013-06-14 00:42 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2013-06-14 00:49 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2013-06-14 00:17:28 PDT
(In reply to comment #0) > Compiling only WK1 like it's doing by the bots is not working due to missing symbols: > Tools/Scripts/build-webkit --release --gtk --no-webkit2 By bots I mean the GTK+ WK1 EWS.
Manuel Rego Casasnovas
Comment 2 2013-06-14 00:20:15 PDT
Created attachment 204678 [details] Patch
Manuel Rego Casasnovas
Comment 3 2013-06-14 00:42:45 PDT
Created attachment 204679 [details] Patch WK1 build fails without this symbols while WK2 build works properly. As expxpected WK1 + WK2 build fails too.
Carlos Garcia Campos
Comment 4 2013-06-14 00:46:35 PDT
Comment on attachment 204679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204679&action=review > ChangeLog:9 > + * Source/autotools/symbols.filter: Added missing symbols when compiling > + only WK1. This comment is confusing, because this file is common for wk1 and wk2, I would say something like: Added missing symbols *needed* when compiling WK1. Removing also the "only" because they are also needed when building both wk1 and wk2.
Manuel Rego Casasnovas
Comment 5 2013-06-14 00:49:07 PDT
Created attachment 204680 [details] Patch Fix ChangeLog message.
WebKit Commit Bot
Comment 6 2013-06-14 01:20:35 PDT
Comment on attachment 204680 [details] Patch Clearing flags on attachment: 204680 Committed r151583: <http://trac.webkit.org/changeset/151583>
WebKit Commit Bot
Comment 7 2013-06-14 01:20:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.