Bug 117627

Summary:

Extra whitespace in blank line in PlatformPopupMenuData.cpp

Product:

WebKit

Reporter:

Santosh Mahto <santosh.ma>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

commit-queue

Priority:

Version:

525.x (Safari 3.2)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from APPLE-EWS-5 for win-future	none
Patch	none

Santosh Mahto

Reported 2013-06-13 21:50:15 PDT

extra space in blank lines at line number:66

Attachments
Patch (1.21 KB, patch) 2013-06-13 21:52 PDT, Santosh Mahto	no flags	Details Formatted Diff Diff
Archive of layout-test-results from APPLE-EWS-5 for win-future (786.82 KB, application/zip) 2013-06-14 12:50 PDT, Build Bot	no flags	Details
Patch (1.18 KB, patch) 2013-06-16 02:02 PDT, Santosh Mahto	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Santosh Mahto

Comment 1 2013-06-13 21:52:51 PDT

Created attachment 204673 [details] Patch

Build Bot

Comment 2 2013-06-14 12:50:21 PDT

Comment on attachment 204673 [details] Patch Attachment 204673 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/867173 New failing tests: fast/media/mq-transform-03.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html

Build Bot

Comment 3 2013-06-14 12:50:22 PDT

Created attachment 204732 [details] Archive of layout-test-results from APPLE-EWS-5 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Santosh Mahto

Comment 4 2013-06-16 02:02:07 PDT

Created attachment 204785 [details] Patch

Brent Fulgham

Comment 5 2013-06-17 23:03:31 PDT

Comment on attachment 204785 [details] Patch It's great to clean these whitespace issues up, but I think in the future it would be more helpful to do a few at once. It's probably not worth the build bot time and review time to correct something like this.

WebKit Commit Bot

Comment 6 2013-06-17 23:24:25 PDT

Comment on attachment 204785 [details] Patch Clearing flags on attachment: 204785 Committed r151669: <http://trac.webkit.org/changeset/151669>

WebKit Commit Bot

Comment 7 2013-06-17 23:24:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.