Bug 117627 - Extra whitespace in blank line in PlatformPopupMenuData.cpp
Summary: Extra whitespace in blank line in PlatformPopupMenuData.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 525.x (Safari 3.2)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-13 21:50 PDT by Santosh Mahto
Modified: 2013-06-17 23:24 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2013-06-13 21:52 PDT, Santosh Mahto 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-5 for win-future (786.82 KB, application/zip)
2013-06-14 12:50 PDT, Build Bot 		no flags Details
Patch (1.18 KB, patch)
2013-06-16 02:02 PDT, Santosh Mahto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Santosh Mahto 2013-06-13 21:50:15 PDT 
extra space in blank lines at line number:66
Comment 1 Santosh Mahto 2013-06-13 21:52:51 PDT 
Created attachment 204673 [details]
Patch
Comment 2 Build Bot 2013-06-14 12:50:21 PDT 
Comment on attachment 204673 [details]
Patch

Attachment 204673 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/867173

New failing tests:
fast/media/mq-transform-03.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html
Comment 3 Build Bot 2013-06-14 12:50:22 PDT 
Created attachment 204732 [details]
Archive of layout-test-results from APPLE-EWS-5 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-5  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 4 Santosh Mahto 2013-06-16 02:02:07 PDT 
Created attachment 204785 [details]
Patch
Comment 5 Brent Fulgham 2013-06-17 23:03:31 PDT 
Comment on attachment 204785 [details]
Patch

It's great to clean these whitespace issues up, but I think in the future it would be more helpful to do a few at once.  It's probably not worth the build bot time and review time to correct something like this.
Comment 6 WebKit Commit Bot 2013-06-17 23:24:25 PDT 
Comment on attachment 204785 [details]
Patch

Clearing flags on attachment: 204785

Committed r151669: <http://trac.webkit.org/changeset/151669>
Comment 7 WebKit Commit Bot 2013-06-17 23:24:27 PDT 
All reviewed patches have been landed.  Closing bug.