Bug 117597

Summary: Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 158729    
Attachments:
Description Flags
Patch eric.carlson: review+

Jer Noble
Reported 2013-06-13 09:09:26 PDT
Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.
Attachments
Patch (9.57 KB, patch)
2013-06-13 09:45 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-06-13 09:45:07 PDT
Created attachment 204623 [details] Patch
Eric Carlson
Comment 2 2013-06-13 10:38:24 PDT
Comment on attachment 204623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204623&action=review Nice rework! > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:102 > +- (void)setupVideoOverlay:(CALayer*)layer Nit: you should have a space before the "*" > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:146 > + QTMovie* movie = _mediaElement->platformMedia().media.qtMovie; > + QTMovieLayer* layer = [[getQTMovieLayerClass() alloc] init]; Nit: ObjC types get the "*" next to the variable name. > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:159 > + AVPlayer* player = _mediaElement->platformMedia().media.avfMediaPlayer; > + AVPlayerLayer* layer = [[getAVPlayerLayerClass() alloc] init]; Ditto. > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:194 > + CALayer* layer = [[[self window] contentView] layer]; Ditto. > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:433 > // MARK: - > // MARK: QTMovie callbacks > Nit: you might want to move this below rateChanged: since it is no longer QTKit-specific.
Jer Noble
Comment 3 2013-06-14 15:29:29 PDT
Committed r151608: <http://trac.webkit.org/changeset/151608>
Note You need to log in before you can comment on or make changes to this bug.